modified to enable sync only after GIT_SYNC_INTERVAL #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, this indeed looks very sensible! One nit: There is a bunch of whitespace changes, could you please clean those up? I find it hard to review as it is. |
|
@simonthum apologies vscode messes with formatting for shell script that doesnt have a |
|
Hi, it's fine now. Please rebase it to apply cleanly and I will accept the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of git-sync-on-inotify syncs continuously whenever an edit is made. This modification ensures that the sync waits until GIT_SYNC_INTERVAL until the next sync is made, thus reducing the number of commits