maxClients > 0 configuration doesn't fail now #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulshv
commented
Mar 9, 2016
ulshv
commented
- Change deprecated 'io.sockets.clients' in clientsInRoom() to another function.
- Update socket.io-client to latest version (1.4.5). Previous version (0.9) fails in Node v.4.x (because of nan). Ran test.js - everything ok.
- Also made some small fixes.
|
this is a big issue affecting many users, see #97, #79, #76 |
|
On 06-Apr-2017 8:44 PM, Yann <[email protected]> wrote:this is a big issue affecting many users, see #97, #79, #76
@andyetOps: any way for you to merge this and the other pull requests?
—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.
|
sanrodari
added a commit
to sanrodari/signalmaster
that referenced
this pull request
Sep 19, 2017
|
What's the status of this PR? |
|
Any update on this PR? |
|
Tried changing the socket.io-client to latest version (1.4.5) and changed the lines 'io.sockets.clients' in sockets.js to the ones in the PR and it worked. This fixed the major issue 'fn.bind is not a function which was result of the deprecated 'io.sockets.clients'. Thanks @ulshv |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.