Ep/feature/tickets list UI #142
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoyarinMax
requested changes
Nov 12, 2024
Comment on lines
+89
to
+91
| val toolbarFilter = findViewById<ImageButton>(R.id.psd_toolbar_filter_ib) | ||
| val toolbarQr = findViewById<ImageButton>(R.id.psd_toolbar_qr_ib) | ||
| val ticketsRv = findViewById<RecyclerView>(R.id.tickets_rv) |
|
|
||
| override fun finish() { | ||
| super.finish() | ||
| PyrusServiceDesk.onServiceDeskStop() |
There was a problem hiding this comment.
Не очень понял смылс этого
|
|
||
| /** | ||
| * Available types of entries. Used for speed optimization to avoid class casting. | ||
| * TODO check the possibility of using sealed classes for this purpose. |
There was a problem hiding this comment.
Да, проще будет sealed классами
There was a problem hiding this comment.
Или можно взять наш кастомный адаптер из основного проекта
There was a problem hiding this comment.
пока тоже нет необходимости, вообще класс лишний
|
|
||
| private var unreadCount = 0 | ||
|
|
||
| private companion object { |
There was a problem hiding this comment.
companion object
Размещаем внизу
There was a problem hiding this comment.
конкретно здесь пока вообще не нужен удалила
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.