Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined variable in saturated regions detection #22

Merged
merged 11 commits into from
May 2, 2024

Conversation

zeehio
Copy link
Member

@zeehio zeehio commented Apr 29, 2024

Would you @clarissefm like to try this fix?

remotes::install_github("sipss/GCIMS#22")

@lalo-caballero is it good for you if I merge this fix?

Closes #21

@zeehio
Copy link
Member Author

zeehio commented Apr 30, 2024

@lalo-caballero The first commit fixes issue #21. All the other commits fix several maintenance/documentation issues I found, so the continuous integration keeps working.

@lalo-caballero lalo-caballero merged commit 9dad01e into master May 2, 2024
2 checks passed
@lalo-caballero
Copy link
Collaborator

Thank you @zeehio

@zeehio zeehio deleted the fix/21-saturated-regions branch May 2, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

find_regions_rip_saturated
2 participants