Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

Commit

Permalink
Removed User Timing performance advice: If you don't use user timings…
Browse files Browse the repository at this point in the history
…, you shouldn't get lower score #148
  • Loading branch information
soulgalore committed Jan 15, 2017
1 parent dfd0bf2 commit c183053
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 31 deletions.
10 changes: 7 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
# CHANGELOG - webcoach
## UNRELEASED
### Changed
- Removed User Timing performance advice: If you don't use user timings, you shouldn't get lower score. See how this was broken https://github.com/sitespeedio/browsertime/issues/257 [#148](https://github.com/sitespeedio/coach/issues/148)

## 0.30.4 2017-01-10
### Added
- Updated to latest Browserime beta-23
Expand All @@ -12,14 +16,14 @@
- Updated to latest Browserime beta-21

## 0.30.1 2017-01-04
### Added
### Added
- Updated to latest Browserime beta-19

## 0.30.0 2016-12-12
### Added
- Add --viewPort option to set browser window size for test, thank you @jsocol for the PR

- New advice "Avoid using incorrect mime types" thank you @lbod #204
- New advice "Avoid using incorrect mime types" thank you @lbod #204

- New Browsertime and PageXray

Expand All @@ -35,7 +39,7 @@
- Updated to latest Browserime beta-9

## 0.28.3 2016-10-26
### Fixed
### Fixed
- Fix the labelOnInput advice (thanks @simonc!)

### Added
Expand Down
14 changes: 14 additions & 0 deletions lib/dom/info/userTiming.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
(function() {
'use strict';

var mark = 0;
var measure = 0;
if (window.performance && window.performance.getEntriesByType) {
measure = window.performance.getEntriesByType('measure').length;
mark = window.performance.getEntriesByType('mark').length;
}
return {
marks: mark,
measures: measure
};
})();
28 changes: 0 additions & 28 deletions lib/dom/performance/userTiming.js

This file was deleted.

1 comment on commit c183053

@tobli
Copy link
Member

@tobli tobli commented on c183053 Feb 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to remove the usertiming tests as well

Please sign in to comment.