ci: Add Are The Types Wrong, Improve Turbo Caching for Fake Root

skyblock-finance · Apr 20, 2024 · bdc339e · bdc339e
1 parent c3f04fe
commit bdc339e
Show file tree

Hide file tree

Showing 7 changed files with 20 additions and 31 deletions.
diff --git a/bun.lockb b/bun.lockb
diff --git a/internals/eslint-config/source/index.ts b/internals/eslint-config/source/index.ts
@@ -20,6 +20,7 @@ export default {
 				reportUnusedDisableDirectives: 'error',
 			},
 			rules: {
+				'@typescript-eslint/consistent-type-definitions': ['error', 'type'],
 				'@typescript-eslint/no-unused-vars': [
 					'warn',
 					{

diff --git a/internals/fake-root/turbo.json b/internals/fake-root/turbo.json
@@ -4,42 +4,22 @@
 	"pipeline": {
 		"check:eslint": {
 			"inputs": [
-				"../../**/*.{cjs,js,mjs,json,mjs,mts,ts}",
-				"!../../internals/**/*",
-				"!../../packages/**/*",
+				"../../*.{cjs,js,mjs,json,mjs,mts,ts}",
 				"../../eslint.config.mjs"
-			],
-			"outputMode": "new-only",
-			"outputs": ["./dist/**"]
+			]
 		},
 		"check:prettier": {
-			"inputs": [
-				"../../**/*.{cjs,js,mjs,json,mjs,mts,ts}",
-				"!../../packages/**/*",
-				"../../eslint.config.mjs"
-			],
-			"outputMode": "new-only",
-			"outputs": ["./dist/**"]
+			"inputs": ["../../*.{cjs,js,mjs,json,mjs,mts,ts}"],
+			"outputMode": "new-only"
 		},
 		"download": {},
 		"fix:eslint": {
-			"inputs": [
-				"../../**/*.{cjs,js,mjs,json,mjs,mts,ts}",
-				"!../../internals/**/*",
-				"!../../packages/**/*",
-				"../../eslint.config.mjs"
-			],
-			"outputMode": "new-only",
-			"outputs": ["./dist/**"]
+			"inputs": ["../../*.{cjs,js,mjs,json,mjs,mts,ts}"],
+			"outputMode": "new-only"
 		},
 		"fix:prettier": {
-			"inputs": [
-				"../../**/*.{cjs,js,mjs,json,mjs,mts,ts}",
-				"!../../packages/**/*",
-				"../../eslint.config.mjs"
-			],
-			"outputMode": "new-only",
-			"outputs": ["./dist/**"]
+			"inputs": ["../../*.{cjs,js,mjs,json,mjs,mts,ts}"],
+			"outputMode": "new-only"
 		},
 		"watch": {
 			"cache": false,

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
 	"devDependencies": {
+		"@arethetypeswrong/cli": "^0.15.3",
 		"@skyblock-finance/eslint-config": "*",
-		"@types/bun": "latest",
 		"eslint": "^9.0.0",
 		"knip": "^5.9.4",
 		"nodemon": "^3.1.0",
@@ -20,6 +20,7 @@
 	"scripts": {
 		"build": "turbo run build",
 		"check": "turbo run check",
+		"check:arethetypeswrong": "turbo run check:arethetypeswrong",
 		"check:eslint": "turbo run check:eslint",
 		"check:knip": "turbo run check:knip",
 		"check:prettier": "turbo run check:prettier",

diff --git a/packages/schemas/package.json b/packages/schemas/package.json
@@ -6,9 +6,9 @@
 		"zod": "^3.22.4"
 	},
 	"devDependencies": {
+		"@types/bun": "latest",
 		"@types/json-stable-stringify": "^1.0.36",
 		"@types/lodash": "^4.14.188",
-		"@types/node": "^18.11.9",
 		"json-stable-stringify": "^1.1.1",
 		"lodash": "^4.17.21",
 		"tslog": "^4.9.2"
@@ -34,6 +34,7 @@
 	},
 	"scripts": {
 		"build": "rm -rf dist && tsc --build",
+		"check:arethetypeswrong": "bun --bun run attw --pack .",
 		"check:eslint": "bun run eslint --max-warnings=0 .",
 		"check:prettier": "bun --bun run --cwd ../.. prettier --check packages/schemas",
 		"check:publint": "bun --bun run publint",

diff --git a/packages/schemas/scripts/download-data.ts b/packages/schemas/scripts/download-data.ts
@@ -6,7 +6,7 @@ import { Logger } from 'tslog'
 
 export const log = new Logger()
 
-interface Common {
+type Common = {
 	name: string
 }
 

diff --git a/turbo.json b/turbo.json
@@ -7,12 +7,18 @@
 		},
 		"check": {
 			"dependsOn": [
+				"check:arethetypeswrong",
 				"check:eslint",
 				"check:knip",
 				"check:prettier",
 				"check:publint"
 			]
 		},
+		"check:arethetypeswrong": {
+			"dependsOn": ["build"],
+			"inputs": ["dist/**", "package.json"],
+			"outputMode": "new-only"
+		},
 		"check:eslint": {
 			"dependsOn": ["@skyblock-finance/eslint-config#build"],
 			"inputs": [