Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Add full_response option for Web client and requests #379

Closed
wants to merge 1 commit into from
Closed

RFC: Add full_response option for Web client and requests #379

wants to merge 1 commit into from

Conversation

jmanian
Copy link
Collaborator

@jmanian jmanian commented Jun 16, 2021

Here's a possible solution to #378. No tests or documentation yet.

@jmanian jmanian requested a review from dblock June 16, 2021 22:13
@dblock
Copy link
Collaborator

dblock commented Jun 17, 2021

This is very bad ™️ IMO because an API should never return two different response types.

@jmanian jmanian mentioned this pull request Jun 17, 2021
Open
@jmanian
Copy link
Collaborator Author

jmanian commented Jun 17, 2021

See #378

@jmanian jmanian closed this Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock Awaiting requested review from dblock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmanian @dblock