fix: default non-defined graphql operations to have 0 complexity

slicknode · Sep 19, 2023 · 4be85d8 · 4be85d8
1 parent fa1f9d5
commit 4be85d8
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 2 deletions.
diff --git a/src/QueryComplexity.ts b/src/QueryComplexity.ts
@@ -238,9 +238,13 @@ export default class QueryComplexity {
       | FragmentDefinitionNode
       | InlineFragmentNode
       | OperationDefinitionNode,
-    typeDef: GraphQLObjectType | GraphQLInterfaceType | GraphQLUnionType
+    typeDef:
+      | GraphQLObjectType
+      | GraphQLInterfaceType
+      | GraphQLUnionType
+      | undefined
   ): number {
-    if (node.selectionSet) {
+    if (node.selectionSet && typeDef) {
       let fields: GraphQLFieldMap<any, any> = {};
       if (
         typeDef instanceof GraphQLObjectType ||

diff --git a/src/__tests__/QueryComplexity-test.ts b/src/__tests__/QueryComplexity-test.ts
@@ -891,4 +891,25 @@ describe('QueryComplexity analysis', () => {
     expect(errors).to.have.length(1);
     expect(errors[0].message).to.contain('INVALIDVALUE');
   });
+
+  it('falls back to 0 complexity for GraphQL operations not supported by the schema', () => {
+    const ast = parse(`
+      subscription {
+        foo
+      }
+    `);
+
+    const errors = validate(schema, ast, [
+      createComplexityRule({
+        maximumComplexity: 1000,
+        estimators: [
+          simpleEstimator({
+            defaultComplexity: 1,
+          }),
+        ],
+      }),
+    ]);
+
+    expect(errors).to.have.length(0);
+  });
 });