Fix health check controller, also add basic controller tests and cove…

…rage tool

.gitignore

@@ -47,3 +47,6 @@ yarn-debug.log*
 !/app/assets/builds/.keep
 
 .DS_Store
+
+coverage
+

Gemfile

@@ -75,4 +75,5 @@ group :test do
   gem 'capybara'
   gem 'capybara-screenshot'
   gem 'webmock'
+  gem 'simplecov', require: false
 end

Gemfile.lock

@@ -126,6 +126,7 @@ GEM
       irb (>= 1.5.0)
       reline (>= 0.3.1)
     diff-lcs (1.5.0)
+    docile (1.4.0)
     domain_name (0.6.20231109)
     dotenv (2.8.1)
     dotenv-rails (2.8.1)
@@ -388,6 +389,12 @@ GEM
       rexml (~> 3.2, >= 3.2.5)
       rubyzip (>= 1.2.2, < 3.0)
       websocket (~> 1.0)
+    simplecov (0.22.0)
+      docile (~> 1.1)
+      simplecov-html (~> 0.11)
+      simplecov_json_formatter (~> 0.1)
+    simplecov-html (0.12.3)
+    simplecov_json_formatter (0.1.4)
     smart_properties (1.17.0)
     snaky_hash (2.0.1)
       hashie
@@ -506,6 +513,7 @@ DEPENDENCIES
   ruby-lsp-rails
   rubyzip
   selenium-webdriver
+  simplecov
   solargraph
   sprockets-rails
   stimulus-rails

app/controllers/health_check_controller.rb

@@ -1,7 +1,6 @@
 class HealthCheckController < ApplicationController
   skip_before_action :authenticate
   skip_after_action :verify_authorized
-  skip_after_action :verify_policy_scoped
   skip_before_action :set_menu_context
 
   def show

test/integration/health_check_test.rb

@@ -0,0 +1,21 @@
+require "test_helper"
+
+class HealthCheckTest < ActionDispatch::IntegrationTest
+  test "healthcheck responds with 200 OK" do
+    get '/health/'
+
+    assert_response :success
+  end
+
+  test "failing jobs healthcheck responds with 200 OK" do
+    get '/health/jobs/failing'
+
+    assert_response :success
+  end
+
+  test "stuck jobs healthcheck responds with 200 OK" do
+    get '/health/jobs/stuck'
+
+    assert_response :success
+  end
+end

test/test_helper.rb

@@ -1,3 +1,6 @@
+require 'simplecov'
+SimpleCov.start 'rails'
+
 ENV['RAILS_ENV'] ||= 'test'
 require_relative "../config/environment"
 require "rails/test_help"