Skip to content

Commit

Permalink
Update tests & Make general agenda fields required
Browse files Browse the repository at this point in the history
  • Loading branch information
@luciajanikova
luciajanikova committed Dec 6, 2023
1 parent e0e6b5e commit 346146c
Show file tree
Hide file tree
Showing 3 changed files with 50 additions and 50 deletions.
8 changes: 4 additions & 4 deletions db/seeds.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@
Upvs::MessageTemplate.find_or_create_by!(
name: 'Všeobecná agenda',
content: '<GeneralAgenda xmlns="http://schemas.gov.sk/form/App.GeneralAgenda/1.9">
<subject>{{ Predmet:text_field }}</subject>
<text>{{ Text:text_area }}</text>
<subject>{{ Predmet*:text_field }}</subject>
<text>{{ Text*:text_area }}</text>
</GeneralAgenda>',
metadata: {
posp_id: 'App.GeneralAgenda',
Expand All @@ -47,8 +47,8 @@
Upvs::MessageTemplate.find_or_create_by!(
name: MessageTemplate::REPLY_TEMPLATE_NAME,
content: '<GeneralAgenda xmlns="http://schemas.gov.sk/form/App.GeneralAgenda/1.9">
<subject>{{ Predmet:text_field }}</subject>
<text>{{ Text:text_area }}</text>
<subject>{{ Predmet*:text_field }}</subject>
<text>{{ Text*:text_area }}</text>
</GeneralAgenda>',
metadata: {
posp_id: 'App.GeneralAgenda',
Expand Down
90 changes: 45 additions & 45 deletions test/lib/message_template_parser_test.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,17 @@ class MessageTemplateParserTest < ActiveSupport::TestCase

assert_equal template_items.count, 2

assert_equal template_items.first[:placeholder], "{{ Predmet:text_field }}"
assert_equal template_items.first[:name], "Predmet"
assert_equal template_items.first[:required], false
assert_equal template_items.first[:default_value], nil
assert_equal template_items.first[:type], "text_field"
assert_equal '{{ Predmet:text_field }}', template_items.first[:placeholder]
assert_equal 'Predmet', template_items.first[:name]
assert_equal false, template_items.first[:required]
assert_equal nil, template_items.first[:default_value]
assert_equal 'text_field', template_items.first[:type]

assert_equal template_items.second[:placeholder], "{{ Text:text_area }}"
assert_equal template_items.second[:name], "Text"
assert_equal template_items.second[:required], false
assert_equal template_items.second[:default_value], nil
assert_equal template_items.second[:type], "text_area"
assert_equal '{{ Text:text_area }}', template_items.second[:placeholder]
assert_equal 'Text', template_items.second[:name]
assert_equal false, template_items.second[:required]
assert_equal nil, template_items.second[:default_value]
assert_equal 'text_area', template_items.second[:type]
end

test "should parse template placeholder, its name, default value and type" do
Expand All @@ -28,47 +28,47 @@ class MessageTemplateParserTest < ActiveSupport::TestCase

assert_equal template_items.count, 7

assert_equal template_items.first[:placeholder], '{{ IČO*:text_field }}'
assert_equal template_items.first[:name], 'IČO'
assert_equal template_items.first[:required], true
assert_equal template_items.first[:default_value], nil
assert_equal template_items.first[:type], 'text_field'
assert_equal '{{ IČO*:text_field }}', template_items.first[:placeholder]
assert_equal 'IČO', template_items.first[:name]
assert_equal true, template_items.first[:required]
assert_equal nil, template_items.first[:default_value]
assert_equal 'text_field', template_items.first[:type]

assert_equal template_items.second[:placeholder], '{{ Kontaktná osoba*:text_field:"Ján Suchal" }}'
assert_equal template_items.second[:name], 'Kontaktná osoba'
assert_equal template_items.second[:required], true
assert_equal template_items.second[:default_value], 'Ján Suchal'
assert_equal template_items.second[:type], 'text_field'
assert_equal '{{ Kontaktná osoba*:text_field:"Ján Suchal" }}', template_items.second[:placeholder]
assert_equal 'Kontaktná osoba', template_items.second[:name]
assert_equal true, template_items.second[:required]
assert_equal 'Ján Suchal', template_items.second[:default_value]
assert_equal 'text_field', template_items.second[:type]

assert_equal template_items.third[:placeholder], '{{ Email*:text_field:"[email protected]" }}'
assert_equal template_items.third[:name], 'Email'
assert_equal template_items.third[:required], true
assert_equal template_items.third[:default_value], '[email protected]'
assert_equal template_items.third[:type], 'text_field'
assert_equal '{{ Email*:text_field:"[email protected]" }}', template_items.third[:placeholder]
assert_equal 'Email', template_items.third[:name]
assert_equal true, template_items.third[:required]
assert_equal '[email protected]', template_items.third[:default_value]
assert_equal 'text_field', template_items.third[:type]

assert_equal template_items.fourth[:placeholder], '{{ Telefón*:text_field:"+4190000000" }}'
assert_equal template_items.fourth[:name], 'Telefón'
assert_equal template_items.fourth[:required], true
assert_equal template_items.fourth[:default_value], '+4190000000'
assert_equal template_items.fourth[:type], 'text_field'
assert_equal '{{ Telefón*:text_field:"+4190000000" }}', template_items.fourth[:placeholder]
assert_equal 'Telefón', template_items.fourth[:name]
assert_equal true, template_items.fourth[:required]
assert_equal '+4190000000', template_items.fourth[:default_value]
assert_equal 'text_field', template_items.fourth[:type]

assert_equal template_items.fifth[:placeholder], '{{ Názov prostriedku:text_field:"IRVIN" }}'
assert_equal template_items.fifth[:name], 'Názov prostriedku'
assert_equal template_items.fifth[:required], false
assert_equal template_items.fifth[:default_value], 'IRVIN'
assert_equal template_items.fifth[:type], 'text_field'
assert_equal '{{ Názov prostriedku:text_field:"IRVIN" }}', template_items.fifth[:placeholder]
assert_equal 'Názov prostriedku', template_items.fifth[:name]
assert_equal false, template_items.fifth[:required]
assert_equal 'IRVIN', template_items.fifth[:default_value]
assert_equal 'text_field', template_items.fifth[:type]

assert_equal template_items[5][:placeholder], '{{ Dátum začiatku platnosti*:date_field }}'
assert_equal template_items[5][:name], 'Dátum začiatku platnosti'
assert_equal template_items[5][:required], true
assert_equal template_items[5][:default_value], nil
assert_equal template_items[5][:type], 'date_field'
assert_equal '{{ Dátum začiatku platnosti*:date_field }}', template_items[5][:placeholder]
assert_equal 'Dátum začiatku platnosti', template_items[5][:name]
assert_equal true, template_items[5][:required]
assert_equal nil, template_items[5][:default_value]
assert_equal 'date_field', template_items[5][:type]

assert_equal template_items[6][:placeholder], '{{ Digitálny odtlačok*:text_field }}'
assert_equal template_items[6][:name], 'Digitálny odtlačok'
assert_equal template_items[6][:required], true
assert_equal template_items[6][:default_value], nil
assert_equal template_items[6][:type], 'text_field'
assert_equal '{{ Digitálny odtlačok*:text_field }}', template_items[6][:placeholder]
assert_equal 'Digitálny odtlačok', template_items[6][:name]
assert_equal true, template_items[6][:required]
assert_equal nil, template_items[6][:default_value]
assert_equal 'text_field', template_items[6][:type]

end
end
2 changes: 1 addition & 1 deletion test/models/upvs/message_template_test.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ class Upvs::MessageTemplateTest < ActiveSupport::TestCase

message_template.build_message_from_template(message_draft)

assert_equal message_draft.form.message_object_datum.blob, '<GeneralAgenda xmlns="http://schemas.gov.sk/form/App.GeneralAgenda/1.9"> <subject>Odpoveď</subject> <text>Odpoveď k rozhodnutiu...</text> </GeneralAgenda>'
assert_equal '<GeneralAgenda xmlns="http://schemas.gov.sk/form/App.GeneralAgenda/1.9"> <subject>Odpoveď</subject> <text>Odpoveď k rozhodnutiu...</text> </GeneralAgenda>', message_draft.form.message_object_datum.blob
end
end

0 comments on commit 346146c

Please sign in to comment.