Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GO-293 Forms and templates in UPVS domain #197

Conversation

luciajanikova
Copy link
Member

@luciajanikova luciajanikova commented Nov 23, 2023

TODOs:

  • validacia voci XSD pred podpisom (aby sme vedeli dat hlasku, ze form nie je validny, nie len ze sa podpisane nepodarilo)
  • fix "placeholdra" medzi moznostami v selecte

…to GO-293/forms_and_templates

# Conflicts:
#	app/controllers/message_drafts_controller.rb
#	app/models/upvs/form_related_document.rb
#	app/models/upvs/form_template.rb
#	db/schema.rb
Copy link
Member

@jsuchal jsuchal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ak spravne kukam, tak si zacala od UPVS konca. Ja by som skusil zacat z opacneho konca (core domena) a spravil model DraftTemplate (pripadne len Template?) kde budes vediet vyrobit nejake XML s placeholdermi, bude sa to dat editovat a potom, ked to budem chciet odoslat tak sa pospustaju validacie a nastavia veci tak aby to slo cez upvs.

Cize pri tom template asi bude treba aj urcit aky to je typ spravy - ci to ide cez upvs alebo inak (core domena netusi vlastne co to je a nema preco vediet)

V podstate ako prvy krok vieme asi sa tvarit, ze dovolime poslat hocico (xml) taketo a potom dorobime validacie. Hm?

app/controllers/message_objects_controller.rb Outdated Show resolved Hide resolved
@jsuchal
Copy link
Member

jsuchal commented Nov 29, 2023

@luciajanikova povedz co s tymto lebo tu vidim dva PR na podania/sablony

@luciajanikova
Copy link
Member Author

Toto je UPVS cast (kvoli allowlistom hlavne), nie je to teraz ale uplne aktualne. Dorobim v tom druhom PR co je este nevyhnutne a aktualizujem potom toto.

…to GO-293/forms_and_templates

# Conflicts:
#	db/schema.rb
…ub.com/solver-it-sro/govbox-pro into GO-293/forms_and_templates

# Conflicts:
#	app/components/new_message_component.html.erb
#	app/components/new_message_component.rb
#	app/controllers/message_objects_controller.rb
#	app/javascript/controllers/message_drafts_controller.js
#	app/models/message_draft.rb
#	app/views/messages/new.html.erb
#	db/seeds.rb
@luciajanikova luciajanikova changed the base branch from main to GO-293/forms_and_templates_core_domain December 5, 2023 23:04
@luciajanikova luciajanikova changed the title GO-293 Forms and templates GO-293 Forms and templates in UPVS domain Dec 5, 2023
@luciajanikova luciajanikova requested a review from jsuchal December 5, 2023 23:07
Comment on lines +124 to +125
schema = Nokogiri::XML::Schema(xsd_schema)
document = Nokogiri::XML(message.form.content)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kedze toto ide od pouzivatela musime tu davat pozor na bezpecnost. Mozno @celuchmarek vie z autogramu nejake nastavenia co treba zapnut.

@luciajanikova
Copy link
Member Author

Neviem dosiahnúť takú vec, aby v selecte ten "placeholder" zostal iba placeholderom a nie jednou z moznosti:
image

@luciajanikova
Copy link
Member Author

@jsuchal mergnem toto do jedneho PR (#208), lebo aktualne to je akurat tak zbytocne neprehladne. Dolezite komentare a poznamky preklopim.

@luciajanikova luciajanikova merged commit 2d4a96e into GO-293/forms_and_templates_core_domain Dec 8, 2023
2 of 3 checks passed
@luciajanikova luciajanikova deleted the GO-293/forms_and_templates branch December 8, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants