Fix message reply #230
Fix message reply #230
Conversation
|
Kym nebude test tak to nezoberiem :) |
test/system/message_threads_test.rb
Outdated
| end | ||
|
|
||
| within_message_in_thread(message_one) do | ||
| find_button("Odpovedať").click |
There was a problem hiding this comment.
click_on "Odpovedať" by malo ist
test/system/message_threads_test.rb
Outdated
| find_button("Odoslať").click | ||
| end | ||
|
|
||
| assert GoodJob::Job.count, job_count_previous + 1 |
There was a problem hiding this comment.
Tu over ci sa tam nastavil nejaky status "Sprava sa odosiela" alebo nieco take by tam malo byt vidiet.
test/system/message_threads_test.rb
Outdated
| within_thread_in_listing(thread_issue) do | ||
| click_link | ||
| end |
There was a problem hiding this comment.
Namiesto tohto by som asi zvazil proste visit message_thread_path(thread_issue) nech ten test zacne rovno na tej subpage
test/system/message_threads_test.rb
Outdated
| end | ||
|
|
||
| GoodJob.perform_inline | ||
| assert GoodJob::Job.where(job_class: 'Govbox::SubmitMessageDraftJob').order(scheduled_at: :desc).first |
There was a problem hiding this comment.
Asi nerozumiem naco tu si tie order a first. AK chces vediet ci existuje tak sa spytaj exists?
There was a problem hiding this comment.
Taktiez si myslim, ze toto bude true aj ked nezavolas to nad tym.
There was a problem hiding this comment.
Ordre boli prezitok z inej verzie, ktoru som skusal. perform_inline tam musi byt, inak ten job nenajde. On sa pusta ako perform_later, a zrejme sa aj do tabulky uz dostava nejako asynchronne.
test/system/message_threads_test.rb
Outdated
| within '#new_drafts' do | ||
| fill_in("Predmet", with: "Testovaci predmet") | ||
| fill_in("Text", with: "Testovacie telo") | ||
| unfocus_input |
There was a problem hiding this comment.
Ak robime taketo kuzla tak si napisme do komentu ze preco.
test/system/message_threads_test.rb
Outdated
| fill_in("Predmet", with: "Testovaci predmet") | ||
| fill_in("Text", with: "Testovacie telo") | ||
| unfocus_input | ||
| find("turbo-frame", id: /submittable/, visible: false) |
There was a problem hiding this comment.
Toto tu musi byt? nestaci to pod tym?
test/system/message_threads_test.rb
Outdated
| end | ||
|
|
||
| within '#new_drafts' do | ||
| fill_in("Predmet", with: "Testovaci predmet") |
There was a problem hiding this comment.
V system testoch sa nezvyknu pouzivat na toto zatvorky ale je to vec stylu
test/system/message_threads_test.rb
Outdated
| thread_issue = message_threads(:ssd_main_issue) | ||
| message_one = messages(:ssd_main_issue_one) | ||
|
|
||
| assert_not GoodJob::Job.where(job_class: 'Govbox::SubmitMessageDraftJob').exists? |
There was a problem hiding this comment.
Toto tu tiez asi uz netreba nie?
There was a problem hiding this comment.
Netreba, sorry. Tolkokrat som tam pridaval/odoberal, ze som to tam zabudol
No description provided.