Some changes for Qgauge driver #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Weiss <[email protected]>
Signed-off-by: Luca Weiss <[email protected]>
It's equivalent but this makes it a bit more unified instead of mix-and-match. Signed-off-by: Luca Weiss <[email protected]>
And invert the condition for PROP_CHARGE_FULL
It's 1/10th degree celsius (see sysfs docs) and not 1/1000th degree celsius (see vadc driver)
While PM7250B appears to also support Li-polymer batteries, it's primarily for Li-ion batteries.
Signed-off-by: Luca Weiss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-open of #34 due to GitHub shenanigans
Notably stop hardcoding the SDAM address and instead of the qcom,spmi-sdam driver and access the SDAM via the nvmem framework.
Please test on pm6150 if this works as expected, the driver seems to need some changes for pm7250b to get ocv values there, we just get 0. (edit: this is explained in #34 (comment))