return err if clients fail to connect

smallnest · Jan 28, 2025 · 675b720 · 675b720
1 parent 751e883
commit 675b720
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/client/xclient.go b/client/xclient.go
@@ -305,13 +305,11 @@ func safeCloseClient(client RPCClient) {
 	client.Close()
 }
 
-func (c *xClient) getCachedClient(k string, servicePath, serviceMethod string, args interface{}) (RPCClient, error) {
-	// TODO: improve the lock
-	var client RPCClient
+func (c *xClient) getCachedClient(k string, servicePath, serviceMethod string, _ interface{}) (client RPCClient, err error) {
 	var needCallPlugin bool
 	defer func() {
 		if needCallPlugin {
-			c.Plugins.DoClientConnected(client.GetConn())
+			_, err = c.Plugins.DoClientConnected(client.GetConn())
 		}
 	}()
 
@@ -327,15 +325,15 @@ func (c *xClient) getCachedClient(k string, servicePath, serviceMethod string, a
 
 	c.mu.Lock()
 	defer c.mu.Unlock()
-	
+
 	client = c.findCachedClient(k, servicePath, serviceMethod)
 	if client != nil {
 		if !client.IsClosing() && !client.IsShutdown() {
 			return client, nil
 		}
 		c.deleteCachedClient(client, k, servicePath, serviceMethod)
 	}
-	
+
 	client = c.findCachedClient(k, servicePath, serviceMethod)
 
 	if client == nil || client.IsShutdown() {