Feature/wifi only downloads #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*TestApp: Dynamically created requests: serves to reset download status on repeated requests. Added newly required permissions.
…oadQueue *Better setWifiOnly JavaDoc comment *Test App: Easier to tell if a download request was wifi-only. Only first download is wifi-only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented WiFi-only downloads:
Behavior:
*If WiFi is unavailable, WiFi-only downloads are queued.
*When Wifi connects, WiFi-only downloads are started.
*If WiFi is disabled, it is up to the consuming app or user to enable WiFi.
Api:
*DownloadRequest has a new method for indicating WiFi only: setWifiOnly(boolean, Context).
*This method includes a context to maintain full api backward compatibility.
*Using this requires additional permissions: see permissions section in README. No additional permissions are required until after a WiFi-only DownloadRequest has been added.
Fix:
*When a new download is added to the queue, cancel active downloads with the same destination file.
TestApp:
*Dynamically created requests: serves to reset DownloadRequest status on repeated requests.
*Added newly required permissions for WiFi only.
Thank you for your time and consideration.