fix: ensure values are safely read

smart-host · Aug 1, 2024 · 5c2ee42 · 5c2ee42
1 parent 2622e9f
commit 5c2ee42
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/src/helpers.js b/src/helpers.js
@@ -183,7 +183,7 @@ const getHistory = async ({
 
     hasMore = hasReachedThreshold ? false : has_more;
     cursor = response_metadata.next_cursor;
-    const mergeQueueMessages = messages.filter(({ text }) =>
+    const mergeQueueMessages = (messages || []).filter(({ text }) =>
       text.startsWith(SEARCH_PREFIX),
     );
     mergeQueueMessages.forEach(({ text }) => {
@@ -239,7 +239,7 @@ const findPrInQueue = async ({
   });
 
   return findLast(matches, (message, ...args) => {
-    const { text } = message;
+    const { text } = message || {};
     const { issueNumber: num } = parseTag(text);
     return (
       num.trim() === issueNumber.toString() && filter(message, ...args, matches)

diff --git a/src/modes/alert.js b/src/modes/alert.js
@@ -60,7 +60,7 @@ async function alert({
   core.info(`issues: ${JSON.stringify(filteredIssues, null, 2)}`);
 
   const promises = messagesToAlert.map(async (match) => {
-    const { text } = match;
+    const { text } = match || {};
     const { issueNumber: num } = parseTag(text);
     const prTag = `PR${num}: `;
 

diff --git a/src/modes/cancel.js b/src/modes/cancel.js
@@ -83,7 +83,7 @@ async function cancel({
     return setActionStatus(STATUS.NOT_FOUND);
   }
 
-  const tagSections = parseTag(match.text);
+  const tagSections = parseTag(match?.text);
   const newTag = buildTagFromParse({
     ...tagSections,
     mergeStatus: Q_STATUS.CANCELLED,

diff --git a/src/modes/init.js b/src/modes/init.js
@@ -88,7 +88,7 @@ async function initRole({
     const updatedMsg = await client.chat.update({
       ...chatOptions,
       ts: match.ts,
-      text: match.text,
+      text: match?.text,
       channel: channel.id,
       attachments,
     });

diff --git a/src/modes/merge.js b/src/modes/merge.js
@@ -88,7 +88,7 @@ async function merge({
   if (nextPr) {
     core.info(`next PR: \n${JSON.stringify(nextPr, null, 2)}`);
 
-    const { issueNumber: nextPrNum } = parseTag(nextPr.text);
+    const { issueNumber: nextPrNum } = parseTag(nextPr?.text);
     core.setOutput('next_pr', nextPrNum);
     const watchers = getWatchers(nextPr);
 
@@ -106,7 +106,7 @@ async function merge({
 
   if (isMerged) {
     const promises = older.map(async (msg) => {
-      const { text } = msg;
+      const { text } = msg || {};
       const tagSections = parseTag(text);
       const newTag = buildTagFromParse({
         ...tagSections,