Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix restXml enum map key deserialization #437

Merged
merged 2 commits into from
Jun 1, 2021
Merged

fix restXml enum map key deserialization #437

merged 2 commits into from
Jun 1, 2021

Conversation

rcoh
Copy link
Collaborator

@rcoh rcoh commented Jun 1, 2021

Issue #, if available: #351
Description of changes: Fix bug discovered while adding SQS. Maps with enum keys did not compile because String was hardcoded.

I also added calls to .trim() to fix a couple more spots that were causing rustfmt to error out on trailing whitespace.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rcoh rcoh requested review from jdisanti and a team June 1, 2021 14:26
rcoh added a commit that referenced this pull request Jun 1, 2021
Add support for SQS and usage example. This requires that #437 & #438 are merged first
@rcoh rcoh enabled auto-merge (squash) June 1, 2021 15:40
@rcoh rcoh merged commit a9daa04 into main Jun 1, 2021
@rcoh rcoh deleted the enum-key-map-deser branch June 1, 2021 15:56
rcoh added a commit that referenced this pull request Jun 1, 2021
* add support & example for sqs

Add support for SQS and usage example. This requires that #437 & #438 are merged first

* Add note about unset fields

* Update hello-world.rs

Remove unused import

* Update hello-world.rs

use simpler subscriber instantiation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants