Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Event Stream Sender/Receiver for use in generated types #639

Merged
merged 9 commits into from
Aug 10, 2021
Merged

Implement Event Stream Sender/Receiver for use in generated types #639

merged 9 commits into from
Aug 10, 2021

Conversation

jdisanti
Copy link
Collaborator

@jdisanti jdisanti commented Aug 9, 2021

Motivation and Context

This is more progress towards the Event Stream protocol implementation (#121). This adds Sender and Receiver types that will end up on on the generated Input and Output types.

Testing

  • Unit tested

Checklist

  • I have updated the CHANGELOG

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jdisanti jdisanti requested a review from rcoh August 9, 2021 17:50
Copy link
Collaborator

@rcoh rcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it would be good to clean up the ready vs. not ready state since it seems more like a builder that could be built vs. something stateful

@jdisanti jdisanti requested a review from rcoh August 10, 2021 16:52
@jdisanti jdisanti merged commit dced8c2 into smithy-lang:main Aug 10, 2021
@jdisanti jdisanti deleted the eventstream-send-recv branch August 10, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants