feat: Add support for OperationContextParams #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 15, 2024 10:17
…t for keys() function and [*] expression.
sichanyoo
commented
Aug 17, 2024
Comment on lines
+23
to
+26
| public func add(name: String, value: [String]?) throws { | ||
| try crtContext.add(name: name, value: value) | ||
| } | ||
|
|
There was a problem hiding this comment.
Add runtime method for adding string array endpoint param to endpoint request context using CRT's new binding.
Comment on lines
+137
to
+147
| if (type.equals(ParameterType.STRING)) { | ||
| builder.defaultValue("\"$defaultValue\"") | ||
| } else if (type.equals(ParameterType.STRING_ARRAY)) { | ||
| val elementsWrappedWithEscapedQuotes = defaultValue.toString() | ||
| .removeSurrounding("[", "]") | ||
| .split(", ") | ||
| .joinToString(", ", "[", "]") { "\"$it\"" } | ||
| builder.defaultValue(elementsWrappedWithEscapedQuotes) | ||
| } else { | ||
| builder.defaultValue(defaultValue.toString()) | ||
| } |
There was a problem hiding this comment.
Fix default value handling for endpoint params generator.
| @@ -54,15 +54,13 @@ class JMESPathVisitor( | |||
| val writer: SwiftWriter, | |||
There was a problem hiding this comment.
Changes in this file add support for wildcard flattening expression ([*]) and the keys() function of JMESPath language.
jbelkins
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR
Issue #
SWIFT-1125Description of changes
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.