Avoid Adding Syst to Systman Groups Twice #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug I introduced in #51. We need to return out of SystematicManager::Add after using the alternative overloaded method, otherwise systematics get added to fGroups[""] twice and it rightfully complains
Ok this, #60, and #58 can all be reviewed and merged. When they're in and we have a fix for #55, then the review/merge of #59 will be more straightforward
@dcookman sorry for all the noise! We could have a call if it's easier to discuss the ordering, or just wait til Wednesday's OXO call