Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add evalResourceT #517

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add evalResourceT #517

wants to merge 5 commits into from

Conversation

parsonsmatt
Copy link
Contributor

This PR adds evalResourceT referenced in #516

Happy to add tests or a minor version bump as desired

snoyberg
snoyberg approved these changes Dec 15, 2024
View reviewed changes
Copy link
Owner

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. Holding off on merging since it didn't sound like you were 100% convinced of this addition, but if you want it, I'll merge and release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snoyberg snoyberg snoyberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parsonsmatt @snoyberg