Return status 404 if target channel doesn't exist

See also: #7
snu-quiqcl · Nov 21, 2024 · 4289803 · 4289803
1 parent 84e145c
commit 4289803
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/wlm_server/operation/views.py b/wlm_server/operation/views.py
@@ -29,7 +29,10 @@ def get_running_status(ch: int) -> tuple[bool, bool]:
 @api_view(['POST'])
 def handle_info(request, ch: int):
     user = request.user
-    channel = Channel.objects.get(channel=ch)
+    try:
+        channel = Channel.objects.get(channel=ch)
+    except Channel.DoesNotExist:
+        return HttpResponse(status=404)
     if not channel.teams.contains(user.team):
         return HttpResponse(status=403)
     message_queue: MessageQueue = settings.MESSAGE_QUEUE

diff --git a/wlm_server/setting/views.py b/wlm_server/setting/views.py
@@ -13,7 +13,10 @@
 @api_view(['POST'])
 def handle_info(request, ch: int):
     user = request.user
-    channel = Channel.objects.get(channel=ch)
+    try:
+        channel = Channel.objects.get(channel=ch)
+    except Channel.DoesNotExist:
+        return HttpResponse(status=404)
     if user.team not in channel.teams.all():
         return HttpResponse(status=403)
     message_queue: MessageQueue = settings.MESSAGE_QUEUE