Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile App] Add CodeMagic yaml workflow file #1004

Merged
merged 45 commits into from
Jan 11, 2025

Conversation

KarinBerg
Copy link
Contributor

@KarinBerg KarinBerg commented Jan 6, 2025

Use the CodeMagic yaml file instead of the Workflow Editor in CodeMagic. This enables version control for the CI/CD pipeline.

This version of the CodeMagic yaml does exactly the same as the CodeEditor version we used before.

Summary by CodeRabbit

Summary by CodeRabbit

  • Chores
    • Updated Codemagic CI/CD configuration with new workflows for Android and iOS builds.
    • Added reusable definitions for build instances and environment versions.
    • Implemented version verification script for Flutter.
    • Configured build workflows for staging and production environments.
    • Set up distribution channels including Firebase App Distribution and TestFlight.
    • Enhanced accuracy of Flutter version retrieval in the clean build script.

Copy link

coderabbitai bot commented Jan 6, 2025

📝 Walkthrough

Walkthrough

The pull request introduces a comprehensive Codemagic CI/CD configuration for Android and iOS applications. It defines reusable instance and environment configurations, along with a Flutter version verification script. The configuration establishes multiple workflows for staging and production builds across both platforms, supporting distribution through Firebase App Distribution, TestFlight, and other channels.

Changes

File Changes
codemagic.yaml - Added instance_mac_mini_m2 instance definition
- Added env_versions environment versions
- Added verify_flutter_version script
- Created 5 new workflows: Android staging/production and iOS staging/production with various distribution targets
recipients_app/clean_build.sh - Modified Flutter version retrieval to use grep for improved accuracy

Sequence Diagram

sequenceDiagram
    participant CM as Codemagic
    participant FV as Flutter Version Check
    participant Build as Build Process
    participant Dist as Distribution Platform

    CM->>FV: Verify Flutter Version
    FV-->>CM: Version Validated
    CM->>Build: Initiate Build
    Build->>Dist: Upload Artifacts
    Dist-->>CM: Distribution Complete
Loading

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 386cb00 and c2030dc.

⛔ Files ignored due to path filters (1)
  • recipients_app/ios/Podfile.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • codemagic.yaml (1 hunks)
  • recipients_app/clean_build.sh (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • codemagic.yaml
🔇 Additional comments (1)
recipients_app/clean_build.sh (1)

16-16: Improved version extraction logic

The new implementation using grep -m 1 "^Flutter" is more robust as it specifically targets the Flutter version line.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
public ⬜️ Ignored (Inspect) Visit Preview Jan 11, 2025 7:37pm

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
recipients_app/codemagic.yaml (2)

14-25: Make Flutter version check more robust.

The current implementation might break if Flutter's version output format changes.

-CURRENT_VERSION=$(flutter --version | head -n 1 | awk '{print $2}')
+CURRENT_VERSION=$(flutter --version | grep -oE "Flutter [0-9]+\.[0-9]+\.[0-9]+" | awk '{print $2}')
🧰 Tools
🪛 yamllint (1.35.1)

[error] 14-14: trailing spaces

(trailing-spaces)


1-485: Fix YAML formatting issues.

Multiple formatting issues were detected:

  • Trailing spaces
  • Inconsistent spacing before colons

Run yamllint -f parsable codemagic.yaml and fix the reported issues.

🧰 Tools
🪛 yamllint (1.35.1)

[error] 1-1: trailing spaces

(trailing-spaces)


[error] 8-8: trailing spaces

(trailing-spaces)


[error] 12-12: trailing spaces

(trailing-spaces)


[error] 14-14: trailing spaces

(trailing-spaces)


[error] 31-31: trailing spaces

(trailing-spaces)


[warning] 40-40: too many spaces before colon

(colons)


[error] 41-41: trailing spaces

(trailing-spaces)


[error] 49-49: trailing spaces

(trailing-spaces)


[error] 54-54: trailing spaces

(trailing-spaces)


[error] 65-65: trailing spaces

(trailing-spaces)


[error] 73-73: trailing spaces

(trailing-spaces)


[error] 79-79: trailing spaces

(trailing-spaces)


[error] 103-103: trailing spaces

(trailing-spaces)


[error] 106-106: trailing spaces

(trailing-spaces)


[error] 124-124: trailing spaces

(trailing-spaces)


[warning] 132-132: too many spaces before colon

(colons)


[error] 133-133: trailing spaces

(trailing-spaces)


[error] 141-141: trailing spaces

(trailing-spaces)


[error] 146-146: trailing spaces

(trailing-spaces)


[error] 157-157: trailing spaces

(trailing-spaces)


[error] 171-171: trailing spaces

(trailing-spaces)


[error] 177-177: trailing spaces

(trailing-spaces)


[error] 197-197: trailing spaces

(trailing-spaces)


[error] 211-211: trailing spaces

(trailing-spaces)


[error] 215-215: trailing spaces

(trailing-spaces)


[error] 218-218: trailing spaces

(trailing-spaces)


[warning] 228-228: too many spaces before colon

(colons)


[error] 229-229: trailing spaces

(trailing-spaces)


[error] 234-234: trailing spaces

(trailing-spaces)


[error] 237-237: trailing spaces

(trailing-spaces)


[error] 245-245: trailing spaces

(trailing-spaces)


[error] 252-252: trailing spaces

(trailing-spaces)


[error] 258-258: trailing spaces

(trailing-spaces)


[error] 264-264: trailing spaces

(trailing-spaces)


[error] 282-282: trailing spaces

(trailing-spaces)


[error] 286-286: trailing spaces

(trailing-spaces)


[error] 304-304: trailing spaces

(trailing-spaces)


[error] 307-307: trailing spaces

(trailing-spaces)


[warning] 318-318: too many spaces before colon

(colons)


[error] 319-319: trailing spaces

(trailing-spaces)


[error] 324-324: trailing spaces

(trailing-spaces)


[error] 327-327: trailing spaces

(trailing-spaces)


[error] 335-335: trailing spaces

(trailing-spaces)


[error] 342-342: trailing spaces

(trailing-spaces)


[error] 348-348: trailing spaces

(trailing-spaces)


[error] 354-354: trailing spaces

(trailing-spaces)


[error] 373-373: trailing spaces

(trailing-spaces)


[error] 376-376: trailing spaces

(trailing-spaces)


[error] 394-394: trailing spaces

(trailing-spaces)


[error] 397-397: trailing spaces

(trailing-spaces)


[warning] 407-407: too many spaces before colon

(colons)


[error] 408-408: trailing spaces

(trailing-spaces)


[error] 413-413: trailing spaces

(trailing-spaces)


[error] 416-416: trailing spaces

(trailing-spaces)


[error] 421-421: trailing spaces

(trailing-spaces)


[error] 431-431: trailing spaces

(trailing-spaces)


[error] 438-438: trailing spaces

(trailing-spaces)


[error] 444-444: trailing spaces

(trailing-spaces)


[error] 450-450: trailing spaces

(trailing-spaces)


[error] 468-468: trailing spaces

(trailing-spaces)


[error] 472-472: trailing spaces

(trailing-spaces)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 55b7607 and af9627a.

📒 Files selected for processing (1)
  • recipients_app/codemagic.yaml (1 hunks)
🧰 Additional context used
🪛 yamllint (1.35.1)
recipients_app/codemagic.yaml

[error] 1-1: trailing spaces

(trailing-spaces)


[error] 8-8: trailing spaces

(trailing-spaces)


[error] 12-12: trailing spaces

(trailing-spaces)


[error] 14-14: trailing spaces

(trailing-spaces)


[error] 31-31: trailing spaces

(trailing-spaces)


[warning] 40-40: too many spaces before colon

(colons)


[error] 41-41: trailing spaces

(trailing-spaces)


[error] 49-49: trailing spaces

(trailing-spaces)


[error] 54-54: trailing spaces

(trailing-spaces)


[error] 65-65: trailing spaces

(trailing-spaces)


[error] 73-73: trailing spaces

(trailing-spaces)


[error] 79-79: trailing spaces

(trailing-spaces)


[error] 103-103: trailing spaces

(trailing-spaces)


[error] 106-106: trailing spaces

(trailing-spaces)


[error] 124-124: trailing spaces

(trailing-spaces)


[warning] 132-132: too many spaces before colon

(colons)


[error] 133-133: trailing spaces

(trailing-spaces)


[error] 141-141: trailing spaces

(trailing-spaces)


[error] 146-146: trailing spaces

(trailing-spaces)


[error] 157-157: trailing spaces

(trailing-spaces)


[error] 171-171: trailing spaces

(trailing-spaces)


[error] 177-177: trailing spaces

(trailing-spaces)


[error] 197-197: trailing spaces

(trailing-spaces)


[error] 211-211: trailing spaces

(trailing-spaces)


[error] 215-215: trailing spaces

(trailing-spaces)


[error] 218-218: trailing spaces

(trailing-spaces)


[warning] 228-228: too many spaces before colon

(colons)


[error] 229-229: trailing spaces

(trailing-spaces)


[error] 234-234: trailing spaces

(trailing-spaces)


[error] 237-237: trailing spaces

(trailing-spaces)


[error] 245-245: trailing spaces

(trailing-spaces)


[error] 252-252: trailing spaces

(trailing-spaces)


[error] 258-258: trailing spaces

(trailing-spaces)


[error] 264-264: trailing spaces

(trailing-spaces)


[error] 282-282: trailing spaces

(trailing-spaces)


[error] 286-286: trailing spaces

(trailing-spaces)


[error] 304-304: trailing spaces

(trailing-spaces)


[error] 307-307: trailing spaces

(trailing-spaces)


[warning] 318-318: too many spaces before colon

(colons)


[error] 319-319: trailing spaces

(trailing-spaces)


[error] 324-324: trailing spaces

(trailing-spaces)


[error] 327-327: trailing spaces

(trailing-spaces)


[error] 335-335: trailing spaces

(trailing-spaces)


[error] 342-342: trailing spaces

(trailing-spaces)


[error] 348-348: trailing spaces

(trailing-spaces)


[error] 354-354: trailing spaces

(trailing-spaces)


[error] 373-373: trailing spaces

(trailing-spaces)


[error] 376-376: trailing spaces

(trailing-spaces)


[error] 394-394: trailing spaces

(trailing-spaces)


[error] 397-397: trailing spaces

(trailing-spaces)


[warning] 407-407: too many spaces before colon

(colons)


[error] 408-408: trailing spaces

(trailing-spaces)


[error] 413-413: trailing spaces

(trailing-spaces)


[error] 416-416: trailing spaces

(trailing-spaces)


[error] 421-421: trailing spaces

(trailing-spaces)


[error] 431-431: trailing spaces

(trailing-spaces)


[error] 438-438: trailing spaces

(trailing-spaces)


[error] 444-444: trailing spaces

(trailing-spaces)


[error] 450-450: trailing spaces

(trailing-spaces)


[error] 468-468: trailing spaces

(trailing-spaces)


[error] 472-472: trailing spaces

(trailing-spaces)

🔇 Additional comments (4)
recipients_app/codemagic.yaml (4)

81-85: Ensure consistent build configuration across environments.

The build configurations for staging and production are identical except for the flavor. This is good practice for maintaining parity between environments.

Also applies to: 179-183


221-222: Verify bundle identifiers across environments.

The bundle identifiers are correctly configured for each environment:

  • Staging: org.socialincome.app.stage
  • Production: org.socialincome.app

Also applies to: 310-311, 400-401


266-270: Ensure consistent build configuration across iOS workflows.

The build configurations are consistent across all iOS workflows, with only the flavor changing between environments. This is good practice.

Also applies to: 356-360, 452-456


39-39: Consider enabling Google Play publishing.

The Google Play publishing configuration is commented out. Consider enabling it to streamline the release process.

Also applies to: 131-131, 194-196

recipients_app/codemagic.yaml Outdated Show resolved Hide resolved
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
codemagic.yaml (2)

95-98: Consider enabling Google Play deployment.

The Google Play deployment configuration is commented out. Consider documenting the timeline or requirements for enabling it.


1-485: Fix YAML formatting issues.

Multiple trailing spaces and colon alignment issues were detected by yamllint.

Run the following to fix formatting:

# Use yamllint to fix formatting:
# 1. Remove trailing spaces
# 2. Fix colon alignment in environment sections
🧰 Tools
🪛 yamllint (1.35.1)

[error] 1-1: trailing spaces

(trailing-spaces)


[error] 8-8: trailing spaces

(trailing-spaces)


[error] 12-12: trailing spaces

(trailing-spaces)


[error] 14-14: trailing spaces

(trailing-spaces)


[error] 31-31: trailing spaces

(trailing-spaces)


[warning] 40-40: too many spaces before colon

(colons)


[error] 41-41: trailing spaces

(trailing-spaces)


[error] 49-49: trailing spaces

(trailing-spaces)


[error] 54-54: trailing spaces

(trailing-spaces)


[error] 65-65: trailing spaces

(trailing-spaces)


[error] 73-73: trailing spaces

(trailing-spaces)


[error] 79-79: trailing spaces

(trailing-spaces)


[error] 103-103: trailing spaces

(trailing-spaces)


[error] 106-106: trailing spaces

(trailing-spaces)


[error] 124-124: trailing spaces

(trailing-spaces)


[warning] 132-132: too many spaces before colon

(colons)


[error] 133-133: trailing spaces

(trailing-spaces)


[error] 141-141: trailing spaces

(trailing-spaces)


[error] 146-146: trailing spaces

(trailing-spaces)


[error] 157-157: trailing spaces

(trailing-spaces)


[error] 171-171: trailing spaces

(trailing-spaces)


[error] 177-177: trailing spaces

(trailing-spaces)


[error] 197-197: trailing spaces

(trailing-spaces)


[error] 211-211: trailing spaces

(trailing-spaces)


[error] 215-215: trailing spaces

(trailing-spaces)


[error] 218-218: trailing spaces

(trailing-spaces)


[warning] 228-228: too many spaces before colon

(colons)


[error] 229-229: trailing spaces

(trailing-spaces)


[error] 234-234: trailing spaces

(trailing-spaces)


[error] 237-237: trailing spaces

(trailing-spaces)


[error] 245-245: trailing spaces

(trailing-spaces)


[error] 252-252: trailing spaces

(trailing-spaces)


[error] 258-258: trailing spaces

(trailing-spaces)


[error] 264-264: trailing spaces

(trailing-spaces)


[error] 282-282: trailing spaces

(trailing-spaces)


[error] 286-286: trailing spaces

(trailing-spaces)


[error] 304-304: trailing spaces

(trailing-spaces)


[error] 307-307: trailing spaces

(trailing-spaces)


[warning] 318-318: too many spaces before colon

(colons)


[error] 319-319: trailing spaces

(trailing-spaces)


[error] 324-324: trailing spaces

(trailing-spaces)


[error] 327-327: trailing spaces

(trailing-spaces)


[error] 335-335: trailing spaces

(trailing-spaces)


[error] 342-342: trailing spaces

(trailing-spaces)


[error] 348-348: trailing spaces

(trailing-spaces)


[error] 354-354: trailing spaces

(trailing-spaces)


[error] 373-373: trailing spaces

(trailing-spaces)


[error] 376-376: trailing spaces

(trailing-spaces)


[error] 394-394: trailing spaces

(trailing-spaces)


[error] 397-397: trailing spaces

(trailing-spaces)


[warning] 407-407: too many spaces before colon

(colons)


[error] 408-408: trailing spaces

(trailing-spaces)


[error] 413-413: trailing spaces

(trailing-spaces)


[error] 416-416: trailing spaces

(trailing-spaces)


[error] 421-421: trailing spaces

(trailing-spaces)


[error] 431-431: trailing spaces

(trailing-spaces)


[error] 438-438: trailing spaces

(trailing-spaces)


[error] 444-444: trailing spaces

(trailing-spaces)


[error] 450-450: trailing spaces

(trailing-spaces)


[error] 468-468: trailing spaces

(trailing-spaces)


[error] 472-472: trailing spaces

(trailing-spaces)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between af9627a and f5abd8f.

📒 Files selected for processing (1)
  • codemagic.yaml (1 hunks)
🧰 Additional context used
🪛 yamllint (1.35.1)
codemagic.yaml

[error] 1-1: trailing spaces

(trailing-spaces)


[error] 8-8: trailing spaces

(trailing-spaces)


[error] 12-12: trailing spaces

(trailing-spaces)


[error] 14-14: trailing spaces

(trailing-spaces)


[error] 31-31: trailing spaces

(trailing-spaces)


[warning] 40-40: too many spaces before colon

(colons)


[error] 41-41: trailing spaces

(trailing-spaces)


[error] 49-49: trailing spaces

(trailing-spaces)


[error] 54-54: trailing spaces

(trailing-spaces)


[error] 65-65: trailing spaces

(trailing-spaces)


[error] 73-73: trailing spaces

(trailing-spaces)


[error] 79-79: trailing spaces

(trailing-spaces)


[error] 103-103: trailing spaces

(trailing-spaces)


[error] 106-106: trailing spaces

(trailing-spaces)


[error] 124-124: trailing spaces

(trailing-spaces)


[warning] 132-132: too many spaces before colon

(colons)


[error] 133-133: trailing spaces

(trailing-spaces)


[error] 141-141: trailing spaces

(trailing-spaces)


[error] 146-146: trailing spaces

(trailing-spaces)


[error] 157-157: trailing spaces

(trailing-spaces)


[error] 171-171: trailing spaces

(trailing-spaces)


[error] 177-177: trailing spaces

(trailing-spaces)


[error] 197-197: trailing spaces

(trailing-spaces)


[error] 211-211: trailing spaces

(trailing-spaces)


[error] 215-215: trailing spaces

(trailing-spaces)


[error] 218-218: trailing spaces

(trailing-spaces)


[warning] 228-228: too many spaces before colon

(colons)


[error] 229-229: trailing spaces

(trailing-spaces)


[error] 234-234: trailing spaces

(trailing-spaces)


[error] 237-237: trailing spaces

(trailing-spaces)


[error] 245-245: trailing spaces

(trailing-spaces)


[error] 252-252: trailing spaces

(trailing-spaces)


[error] 258-258: trailing spaces

(trailing-spaces)


[error] 264-264: trailing spaces

(trailing-spaces)


[error] 282-282: trailing spaces

(trailing-spaces)


[error] 286-286: trailing spaces

(trailing-spaces)


[error] 304-304: trailing spaces

(trailing-spaces)


[error] 307-307: trailing spaces

(trailing-spaces)


[warning] 318-318: too many spaces before colon

(colons)


[error] 319-319: trailing spaces

(trailing-spaces)


[error] 324-324: trailing spaces

(trailing-spaces)


[error] 327-327: trailing spaces

(trailing-spaces)


[error] 335-335: trailing spaces

(trailing-spaces)


[error] 342-342: trailing spaces

(trailing-spaces)


[error] 348-348: trailing spaces

(trailing-spaces)


[error] 354-354: trailing spaces

(trailing-spaces)


[error] 373-373: trailing spaces

(trailing-spaces)


[error] 376-376: trailing spaces

(trailing-spaces)


[error] 394-394: trailing spaces

(trailing-spaces)


[error] 397-397: trailing spaces

(trailing-spaces)


[warning] 407-407: too many spaces before colon

(colons)


[error] 408-408: trailing spaces

(trailing-spaces)


[error] 413-413: trailing spaces

(trailing-spaces)


[error] 416-416: trailing spaces

(trailing-spaces)


[error] 421-421: trailing spaces

(trailing-spaces)


[error] 431-431: trailing spaces

(trailing-spaces)


[error] 438-438: trailing spaces

(trailing-spaces)


[error] 444-444: trailing spaces

(trailing-spaces)


[error] 450-450: trailing spaces

(trailing-spaces)


[error] 468-468: trailing spaces

(trailing-spaces)


[error] 472-472: trailing spaces

(trailing-spaces)

⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Prettify
🔇 Additional comments (6)
codemagic.yaml (6)

2-4: LGTM! Instance configuration is well-defined.

The mac_mini_m2 instance with a 30-minute build duration is appropriate for mobile app builds.


12-25: LGTM! Robust Flutter version verification.

The script effectively ensures version consistency by checking against .tool-versions.

🧰 Tools
🪛 yamllint (1.35.1)

[error] 12-12: trailing spaces

(trailing-spaces)


[error] 14-14: trailing spaces

(trailing-spaces)


28-40: LGTM! Well-structured Android staging workflow.

Good separation of concerns with appropriate environment groups and signing configuration.

🧰 Tools
🪛 yamllint (1.35.1)

[error] 31-31: trailing spaces

(trailing-spaces)


[warning] 40-40: too many spaces before colon

(colons)


179-184: LGTM! Proper production build configuration.

The production workflow correctly uses appbundle format with appropriate flavor and environment variables.


220-223: LGTM! Proper iOS staging bundle configuration.

The bundle identifier and distribution type are correctly configured for TestFlight.


425-426: Verify Firebase configuration path.

Ensure that the path $CM_BUILD_DIR/recipients_app/ios/GoogleServicesConfig exists in the repository.

✅ Verification successful

Firebase configuration path verified

The directory recipients_app/ios/GoogleServicesConfig exists in the repository.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if the Firebase configuration directory exists
fd -t d "GoogleServicesConfig$" recipients_app/ios

Length of output: 93

codemagic.yaml Outdated Show resolved Hide resolved
@KarinBerg KarinBerg changed the title Add CodeMagic yaml workflow file [Mobile App] Add CodeMagic yaml workflow file Jan 6, 2025
@KarinBerg KarinBerg closed this Jan 6, 2025
@KarinBerg KarinBerg reopened this Jan 6, 2025
@KarinBerg KarinBerg marked this pull request as draft January 6, 2025 20:39
@KarinBerg KarinBerg force-pushed the karin/ci/add_codemagic_yaml branch from 746f3b4 to c2030dc Compare January 11, 2025 19:36
@KarinBerg KarinBerg marked this pull request as ready for review January 11, 2025 19:37
@KarinBerg KarinBerg merged commit 9f2ecec into main Jan 11, 2025
16 checks passed
@KarinBerg KarinBerg deleted the karin/ci/add_codemagic_yaml branch January 11, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants