Merge pull request #372 from ZeroPointEnergy/fix/report_parsing

Fix/report parsing

app/models/report.rb

@@ -125,7 +125,7 @@ def self.create_from_yaml(report_yaml)
     # munge will capture metrics about the number of unchanged items
     # then we can remove them to save space in the resource_statuses table
     if SETTINGS.disable_report_unchanged_events
-      report.resource_statuses.delete_if {|rs| rs.status == 'unchanged' }
+      report.resource_statuses.each{|rs| rs.destroy if rs.status == 'unchanged' }
     end
 
     report.save!

spec/models/report_spec.rb

@@ -457,6 +457,20 @@
         myStubbedClass.create_from_yaml_file('/tmp/foo').should == nil
       end
     end
+
+    describe 'disable_report_unchanged_events setting' do
+      let(:report_yaml){ File.read(File.join(Rails.root, 'spec/fixtures/reports/failure.yml')) }
+      let(:report) { Report.create_from_yaml(report_yaml) }
+      it 'should keep all resource statuses per default' do
+        expect(report.resource_statuses.count).to be 9
+        expect(ResourceStatus.count).to be 9
+      end
+      it 'should remove unchanged resource statuses' do
+        SETTINGS.stubs(:disable_report_unchanged_events).returns(true)
+        expect(report.resource_statuses.count).to be 1
+        expect(ResourceStatus.count).to be 1
+      end
+    end
   end