make Connection.isFine check Connection's closed state (#340)

sofastack · Feb 21, 2024 · efeb15a · efeb15a
1 parent 6b127c1
commit efeb15a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/main/java/com/alipay/remoting/Connection.java b/src/main/java/com/alipay/remoting/Connection.java
@@ -157,7 +157,7 @@ private void init() {
      * @return true if connection is fine
      */
     public boolean isFine() {
-        return this.channel != null && this.channel.isActive();
+        return this.channel != null && this.channel.isActive() && !closed.get();
     }
 
     /**

diff --git a/src/test/java/com/alipay/remoting/inner/connection/ConnectionTest.java b/src/test/java/com/alipay/remoting/inner/connection/ConnectionTest.java
@@ -16,6 +16,7 @@
  */
 package com.alipay.remoting.inner.connection;
 
+import com.alipay.remoting.exception.RemotingException;
 import org.junit.After;
 import org.junit.Assert;
 import org.junit.Before;
@@ -123,4 +124,11 @@ public void connectionTest() throws Exception {
         Thread.sleep(100);
         Assert.assertEquals(3, serverConnectProcessor.getConnectTimes());
     }
+
+    @Test
+    public void testIsFine() throws RemotingException {
+        Connection conn = client.createStandaloneConnection(ip, port, 1000);
+        conn.close();
+        Assert.assertFalse(conn.isFine());
+    }
 }