Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettier formatter and pull request template #84

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

shivam178
Copy link
Contributor

Since the project is growing. I feel that we should use a linter.
It was difficult for me initially to understand non-linted code, hence coming forth with this.

  • Formatted all files
  • Added lint check in workflow
  • Added github pull request template

Feel free to update linter rules & github template as per the project best needs.

@shivam178
Copy link
Contributor Author

@sojinantony01 any update on reviewing the PR?

@sojinantony01
Copy link
Owner

@sojinantony01 any update on reviewing the PR?

Please give me 2 more days 🙏

Copy link
Owner

@sojinantony01 sojinantony01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍
Thanks @shivam178

Please use "squash and merge"

@shivam178
Copy link
Contributor Author

Please use "squash and merge"

I cannot merge; i don't have access. 😄
Kindly do the honours. @sojinantony01

@sojinantony01 sojinantony01 merged commit e77da57 into sojinantony01:master Jan 10, 2025
2 checks passed
@shivam178 shivam178 deleted the format-code branch January 10, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants