Skip to content

Commit

Permalink
[Mellanox] Fix SN5600 buffers_defaults_objects.j2 (#21796)
Browse files Browse the repository at this point in the history
<!--
 Please make sure you've read and understood our contributing guidelines:
 https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

 failure_prs.log skip_prs.log Make sure all your commits include a signature generated with `git commit -s` **

 If this is a bug fix, make sure your description includes "fixes #xxxx", or
 "closes #xxxx" or "resolves #xxxx"

 Please provide the following information:
-->

#### Why I did it
To fix buffers_defaults_object.j2 issues:
- missing comma
- missing table name
- use of a removed profile
##### Work item tracking
- Microsoft ADO **(number only)**:

#### How I did it
Updated the file to add comma, table name and use an existing profile
#### How to verify it
config load_minigraph on the switch with Mellanox-SN5600-C256S1 SKU
<!--
If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012.
-->

#### Which release branch to backport (provide reason below if selected)

<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->

- [ ] 201811
- [ ] 201911
- [ ] 202006
- [ ] 202012
- [ ] 202106
- [ ] 202111
- [ ] 202205
- [ ] 202211
- [ ] 202305

#### Tested branch (Please provide the tested image version)

<!--
- Please provide tested image version
- e.g.
- [x] 20201231.100
-->

- [ ] <!-- image version 1 -->
- [ ] <!-- image version 2 -->

#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->

<!--
 Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
-->

#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->

#### A picture of a cute animal (not mandatory but encouraged)
  • Loading branch information
mssonicbld authored Feb 20, 2025
1 parent bfb2278 commit 8425490
Showing 1 changed file with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@
"BUFFER_PORT_INGRESS_PROFILE_LIST": {
{% for port in port_names_active.split(',') %}
"{{ port }}": {
"profile_list" : "ingress_lossless_profile"
"profile_list" : "ingress_lossy_profile"
}{% if not loop.last %},{% endif %}

{% endfor %}
Expand All @@ -114,7 +114,7 @@
{% for port in port_names_inactive.split(',') %}
"{{ port }}": {
{% if dynamic_mode is defined %}
"profile_list" : "ingress_lossless_profile"
"profile_list" : "ingress_lossy_profile"
{% else %}
"profile_list" : "ingress_lossless_zero_profile"
{% endif %}
Expand Down Expand Up @@ -147,7 +147,7 @@
{%- endmacro %}

{%- macro generate_queue_buffers(port_names_active, port_names_inactive) %}

"BUFFER_QUEUE": {
{% if dynamic_mode is not defined %}
{% for port in port_names_active.split(',') %}
"{{ port }}|0": {
Expand Down Expand Up @@ -177,6 +177,7 @@
{% endfor %}
{% if port_names_inactive|length > 0 %}
{% for port in port_names_inactive.split(',') %}
{%- if loop.first -%},{%- endif -%}
"{{ port }}|1-6": {
"profile" : "egress_lossy_zero_profile"
}{% if not loop.last %},{% endif %}
Expand Down

0 comments on commit 8425490

Please sign in to comment.