Disable SA_EQUALS_DA trap on DNX LC SKUs #17206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyiz2021
approved these changes
Nov 17, 2023
|
[line 864] Error: sai_disable_srcmacqedstmac_ctrl is not permitted |
arlakshm
approved these changes
Nov 22, 2023
lguohan
approved these changes
Nov 29, 2023
|
@wenyiz2021 do we have ADO to track the cherry pick? |
|
hi @StormLiangMS I just created ADO: 26018742 to track cherry pick for 202305 |
yxieca
pushed a commit
that referenced
this pull request
Dec 4, 2023
This change was submitted directly to 202205 but it's also needed in master and 202305 with SAI9.x #13346 There has been a couple CSPs for this as well: CS00012273013 - [7.1][J2, J2c+] Disable SA Equals DA trap on DNX CS00012320965 - SAI9.2: iBGP doesn't work due to SA_EQUALS_DA trap If SA_EQUALS_DA trap is enabled iBGP won't work as the Ethernet-IB0 ports are expected to get packets with SA==DA. In the VOQ chassis design, for outgoing control plane packets, the packets goes the recycle port for routing, therefore the dmac of the packet should be the asic router mac. The source mac is assigned by the kernel, so it is also the asic router mac.
|
@StormLiangMS could you help to backport tp 202305 branch? ADO: 26018742 |
|
@arista-nwolfe PR conflicts with 202305 branch |
|
@arista-nwolfe |
StormLiangMS
pushed a commit
that referenced
this pull request
Dec 14, 2023
This is a 202305 cast of this PR #17206
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was submitted directly to
202205but it's also needed inmasterand202305with SAI9.x#13346
There has been a couple CSPs for this as well:
CS00012273013 - [7.1][J2, J2c+] Disable SA Equals DA trap on DNX
CS00012320965 - SAI9.2: iBGP doesn't work due to SA_EQUALS_DA trap
If SA_EQUALS_DA trap is enabled iBGP won't work as the
Ethernet-IB0ports are expected to get packets with SA==DA.E.G. iBGP not working:
Backport: