Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker-orchagent] add -R flag for ring mode in orchagent.sh #19652

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

a114j0y
Copy link

@a114j0y a114j0y commented Jul 22, 2024

Why I did it

Enable the feature in BGP Loading Optimization HLD #1521 GitHub issue/pull request detail

Work item tracking
  • Microsoft ADO (number only):

How I did it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@a114j0y a114j0y marked this pull request as ready for review February 1, 2025 01:10
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yuezhoujk
Copy link

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@@ -101,4 +101,10 @@ if [[ x"${MGMT_VRF_ENABLED}" == x"true" ]]; then
ORCHAGENT_ARGS+=" -v mgmt"
fi

# Enable ring buffer
ORCHDAEMON_RING_ENABLED=`sonic-db-cli CONFIG_DB hget "RING_BUFFER_CONFIG|orchdaemon" "ringBufferEnabled"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RING_BUFFER_CONFIG

seems like a new table in ConfigDB. Could you add it into HLD? Could you add yang model and UT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a114j0y you can find SONiC yang model and test from https://github.com/sonic-net/sonic-buildimage/tree/master/src/sonic-yang-models/

Seems you need a new yang file for RING_BUFFER_CONFIG.

Copy link
Author

@a114j0y a114j0y Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it into the existing table "DEVICE_METADATA | localhost"

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yuezhoujk
Copy link

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yuezhoujk
Copy link

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yuezhoujk
Copy link

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants