-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gNOI Cold Reboot - Adding the framework docker in the sonic-buildimage #20709
base: master
Are you sure you want to change the base?
Conversation
We should probably update the PR title and description. This is mainly adding a new container. |
As discussed, please update README with docker dependencies and update sonic reboot/shutdown sequence accordingly to avoid crashes. Also, please add exceptions around code that is dependent on other containers for better error handling. |
Updated title and description. |
@hdwhdw Pls review |
@vvolam @qiluo-msft Pls review |
80a586a
to
153179c
Compare
Pl. refer to files/build_templates/framework.service.j2 in #20713 where the sequence is taken care |
153179c
to
495aa25
Compare
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
@rkavitha-hcl @kishanps , Is this taken care of? |
495aa25
to
9179ab0
Compare
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
@vvolam , I had already responded to your query. |
… sonic-buildimage
9179ab0
to
768a40a
Compare
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
768a40a
to
80324cb
Compare
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
80324cb
to
9b17a19
Compare
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
@kishanps , kindly review |
@vvolam, could you please review. |
@hdwhdw , could you please review |
Why I did it
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
This PR creates framework docker, which will be managing the Cold/Warm reboot requests from gNOI.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)