Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonic t2 support for radian #21732

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Muckthebuck
Copy link

Why I did it

Adding support for RADIAN feature for SONiC T2

Work item tracking
  • Microsoft ADO (number only):30112967

How I did it

  • Cli commands to add/remove ANCHOR prefix to a PREFIX_LIST table in CONFIG_DB
    • yang model changes for the new table
  • PrefixListMgr to handle add/remove of configuration
  • Templates
    • add_radian/del_radian : to add or remove an anchor prefix list and aggregate address

How to verify it

  • Unit tests : config gen, manager and yang model

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

  • 20250212.2

Description for the changelog

Added support for RADIAN feature for SONiC T2

Link to config_db schema for YANG module changes

New table in config_db: PREFIX_LIST
Prefix list

A picture of a cute animal (not mandatory but encouraged)

image

Copy link

linux-foundation-easycla bot commented Feb 13, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@deepak-singhal0408
Copy link
Contributor

deepak-singhal0408 commented Feb 13, 2025

@Muckthebuck please look into the PR checker failure?

@Muckthebuck Muckthebuck force-pushed the SONiC-T2-support-for-RADIAN branch from 302775b to 0b08de0 Compare February 14, 2025 03:50
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Muckthebuck Muckthebuck force-pushed the SONiC-T2-support-for-RADIAN branch from 0b08de0 to 9ce0f61 Compare February 14, 2025 04:00
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Following files were altered or added:
1. Cli support to add a prefix
	- dockers/docker-fpm-fr/base_image_files/prefix_list
	- rules/docker-fpm-frr.mk
2. Manager to add appropriate prefix using jinja templates

Signed-off-by: Mukul Chodhary <[email protected]>
@Muckthebuck Muckthebuck force-pushed the SONiC-T2-support-for-RADIAN branch from 549cc00 to 3199d27 Compare February 14, 2025 04:35
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Muckthebuck Muckthebuck force-pushed the SONiC-T2-support-for-RADIAN branch from 3199d27 to d214e49 Compare February 14, 2025 04:37
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Muckthebuck Muckthebuck marked this pull request as ready for review February 14, 2025 23:09
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@deepak-singhal0408
Copy link
Contributor

@Muckthebuck can you look into the build failure?

Copy link
Contributor

@deepak-singhal0408 deepak-singhal0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Muckthebuck.. Changes look good to me,

@deepak-singhal0408
Copy link
Contributor

@rlhui, please help merge this PR? Thanks,

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Muckthebuck Muckthebuck force-pushed the SONiC-T2-support-for-RADIAN branch from 06869f2 to 949ebee Compare February 20, 2025 05:07
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Mukul Chodhary <[email protected]>
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

replace IFS in help message with printf

Signed-off-by: Mukul Chodhary <[email protected]>
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

put the table map in correct spot for v4

Signed-off-by: Mukul Chodhary <[email protected]>
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants