-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SmartSwitch] [Nvidia] Remove PG 3 and 4 for Internal Ports #21797
base: master
Are you sure you want to change the base?
[SmartSwitch] [Nvidia] Remove PG 3 and 4 for Internal Ports #21797
Conversation
Signed-off-by: Oleksandr Ivantsiv <[email protected]> Signed-off-by: Vivek Reddy <[email protected]> Co-authored-by: Vivek Reddy <[email protected]>
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
@@ -92,8 +93,7 @@ | |||
"BUFFER_PG": { | |||
"Dpc": { | |||
"active": { | |||
"dynamic": "ingress_lossy_profile", | |||
"static": "ingress_lossy_profile" | |||
"dynamic": "NULL" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oleksandrivantsiv Could you check if WRED is applied on these internal ports? I believe thats also not required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. I recall some qos tests were not passing before. Could you please make sure qos/test_buffer.py passes with this change?
Why I did it
PG's 3 & 4 for Internal ports today have lossy buffer profiles attached, but this is redundant and can be removed as they occupy extra overhead even though it's not significant
Work item tracking
How I did it
Make the cable length for Dpc ports to 0m and create a new TC_PG_MAP for internal ports
How to verify it
Run config qos reload --no-dynamic-buffer, config save -y and config reload -y
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)