Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SmartSwitch] [Nvidia] Remove PG 3 and 4 for Internal Ports #21797

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oleksandrivantsiv
Copy link
Collaborator

Why I did it

PG's 3 & 4 for Internal ports today have lossy buffer profiles attached, but this is redundant and can be removed as they occupy extra overhead even though it's not significant

Work item tracking
  • Microsoft ADO (number only):

How I did it

Make the cable length for Dpc ports to 0m and create a new TC_PG_MAP for internal ports

How to verify it

Run config qos reload --no-dynamic-buffer, config save -y and config reload -y

redis-cli -n 4 hget "CABLE_LENGTH|AZURE" Ethernet224
"0m"
redis-cli -n 4 hget "PORT_QOS_MAP|Ethernet232" tc_to_pg_map
"AZURE_DPC"

root@r-bobcat-01:/home/admin# sonic-db-cli CONFIG_DB HGETALL "TC_TO_PRIORITY_GROUP_MAP|AZURE_DPC"
{'0': '0', '1': '0', '2': '0', '3': '0', '4': '0', '5': '0', '6': '0', '7': '7'}

redis-cli -n 0 keys "BUFFER_PG*Ethernet232*"
1) "BUFFER_PG_TABLE:Ethernet232:0"

redis-cli -n 0 keys "BUFFER_PG*Ethernet88*"
1) "BUFFER_PG_TABLE:Ethernet88:3-4"
2) "BUFFER_PG_TABLE:Ethernet88:0"
2025 Feb 14 11:36:15.333024 sonic NOTICE swss#buffermgrd: :- doSpeedUpdateTask: Not creating/updating PG profile for port Ethernet224. Cable length is set to 0m
2025 Feb 14 11:36:15.333024 sonic NOTICE swss#buffermgrd: :- doSpeedUpdateTask: Not creating/updating PG profile for port Ethernet232. Cable length is set to 0m
2025 Feb 14 11:36:15.333142 sonic NOTICE swss#buffermgrd: :- doSpeedUpdateTask: Not creating/updating PG profile for port Ethernet240. Cable length is set to 0m
2025 Feb 14 11:36:15.333142 sonic NOTICE swss#buffermgrd: :- doSpeedUpdateTask: Not creating/updating PG profile for port Ethernet248. Cable length is set to 0m

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Oleksandr Ivantsiv <[email protected]>
Signed-off-by: Vivek Reddy <[email protected]>
Co-authored-by: Vivek Reddy <[email protected]>
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@@ -92,8 +93,7 @@
"BUFFER_PG": {
"Dpc": {
"active": {
"dynamic": "ingress_lossy_profile",
"static": "ingress_lossy_profile"
"dynamic": "NULL"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oleksandrivantsiv Could you check if WRED is applied on these internal ports? I believe thats also not required.

Copy link
Contributor

@prabhataravind prabhataravind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I recall some qos tests were not passing before. Could you please make sure qos/test_buffer.py passes with this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants