Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FRR]Fixing route update on duplicate link up event in promiscuous mode #21805

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dgsudharsan
Copy link
Collaborator

Why I did it

Fixing route update on duplicate link up event in promiscuous mode. When running tcpdump on interfaces which have BGP neighbors a duplicate link up event is received as the interface enters promiscuous mode. However these shouldn't trigger route updates. Due to the commit 58592be57783a3b24e7351af2a5afc61299768df route updates are published.

2025 Feb 19 18:00:14.893285 r-leopard-72 DEBUG bgp#zebra[36]: [V6YM8-PV4KB] MESSAGE: ZEBRA_INTERFACE_UP PortChannel101 vrf default(0)
2025 Feb 19 18:00:14.893492 r-leopard-72 INFO bgp#staticd[49]: [YGHNZ-57CJY] Interface enabled Removing. PortChannel101 SIDs that depend on the interface
2025 Feb 19 18:01:17.900554 r-leopard-72 DEBUG bgp#zebra[36]: [V6YM8-PV4KB] MESSAGE: ZEBRA_INTERFACE_UP PortChannel101 vrf default(0)
2025 Feb 19 18:01:17.900554 r-leopard-72 DEBUG bgp#zebra[36]: [V6YM8-PV4KB] MESSAGE: ZEBRA_INTERFACE_UP PortChannel102 vrf default(0)
2025 Feb 19 18:01:17.900819 r-leopard-72 INFO bgp#staticd[49]: [YGHNZ-57CJY] Interface enabled Removing. PortChannel101 SIDs that depend on the interface
2025 Feb 19 18:01:17.900819 r-leopard-72 INFO bgp#staticd[49]: [YGHNZ-57CJY] Interface enabled Removing. PortChannel102 SIDs that depend on the interface
2025 Feb 19 18:01:38.689072 r-leopard-72 DEBUG bgp#zebra[36]: [V6YM8-PV4KB] MESSAGE: ZEBRA_INTERFACE_UP Ethernet0 vrf default(0)
2025 Feb 19 18:01:38.689072 r-leopard-72 INFO bgp#staticd[49]: [YGHNZ-57CJY] Interface enabled Removing. Ethernet0 SIDs that depend on the interface
Work item tracking
  • Microsoft ADO (number only):

How I did it

Reverted the commit that causes the issue and added as patch

How to verify it

Running tcpdump on bgp neighbor and verifying if there are no route updates.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@donaldsharp
Copy link

LGTM

@dgsudharsan
Copy link
Collaborator Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dgsudharsan
Copy link
Collaborator Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants