-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deviations from EurKEY 1.3 specifications and add better support for ISO keyboards #1
base: master
Are you sure you want to change the base?
Conversation
- Incorrect placement of ∡ ₊ and ″
Thanks for the kind words and for opening this pull request! Regarding Regarding Regarding the sameness between ANSI and ISO, that was an intentional decision. The specification doesn’t have any guidance regarding ISO layouts and I don’t want one key to suddenly move just because the user switches keyboards, so I mapped both of them to the same characters. Of course, this is not consistent with what is printed on the keys, but I think this is an acceptable trade-off, especially for users of a custom keyboard layout (where the layout often deviates from the printed keycaps). Furthermore, not all (physical) ISO layouts have a §± key there; for example, the German layout has a ^° key. Finally, regarding the help key, I cherry-picked your commit to 1510dda. Out of curiosity, do you still have a keyboard with a Help key or do you use it in another way? |
I just double checked and the specifications and what you say is indeed true. To me it very much looks like an issue caused by "smart quotation marks" ( Regarding the ANSI / ISO differences: The reasoning behind why I suggested moving the `~ key and putting a §± key in its place was because that's how they are positioned in Apples ISO US-layout (neither Windows nor Linux does this). I assume that Apple decided to do this because it is more ergonomic to reach down with your pinky than it is to reach up. As you know, this is remapping is done on the key code level. This means, that the only two viable solutions are to either have a duplicate key when using an ISO keyboard (this is the solution you chose) or letting macOS do it's thing and have the key move. I absolutely understand the reasoning behind your decision, and as someone who uses a (Swiss) German layout himself I am OK with the layout not matching what's printed on the key caps (I'm still trying to get used to z and y being switched). However, I would argue that in this case it actually does make more sense to do it the Apple way:
I think the best solution would to do it the Apple way and then adding a section to the README that explains how you can change the position the keys using the Keyboard Setup Assistant. But in the end the decision is up to you. Regarding the help key: I think Apple stopped producing keyboards that have a help key in 2007. I don't own a keyboard that features a help key, but after all, having it theoretically working doesn't do any harm. |
I’m with you that this seems like a smart quotation mistake. I took a look at EurKEY for Windows which, as far as I know, was developed by the author himself, and AltGr+M+" is mapped to Regarding ANSI and ISO, your suggestion using Keyboard Setup Assistant intrigued me, but it seems like it doesn’t work for my use case. When
Thank you! That was indeed my goal with this implementation, and I hope to make it available through Homebrew too. |
Hi!
Thank's for this great repo. I discovered that the keylayout file contained some minor errors in the α and √ dead key layers. More specifically, the
∡
,₊
and″
symbols were either misplaced or missing.Additionally, on an US keyboard that uses the ISO layout, the `~ key moves between the left shift and z key. In its place there should be a §± key. That way the EurKEY layout remains consistent with what is printed on the keys. This was not the case (instead both keys were exactly the same and produced `~) so I decided to fix this as well.