Adds Width and Height-specific on-board Card Scaling #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted and an action is taken. Combines my size headers into just one instead.
…cessfully without this stuff.
|
Hey, sorry, Spaceman's been busy with other projects and I just noticed there were PRs here. I'm going to hold off on merging this, particularly with the changes to the Gulp being involved. Also, while your changes to improve GM handling seem helfpul, I'm not sure that it calls for full author credit. With that said, I'm entirely unclear on open source ettiquette. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a more verbose error message when a player attempts an action that requires a GM, if a GM is not connected.
I wound up needing to do some edits to the gulpfile and update some packages in order to get the build task to work. This is my first time working with Gulp, though, so that might be a result of me doing something wrong instead.