Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added prop color for a custom background color for the toggle button. #26

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

guastallaigor
Copy link
Contributor

No description provided.

Copy link
Contributor

@damienix damienix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, have you found this pattern (of coloring toggle button) somewhere in Jira or is this something that you came up with for your needs? If it's described somewhere (or used in Jira) I'd be more than happy to see it as I can't find it there.

@guastallaigor
Copy link
Contributor Author

This is something that I came up for my needs. I've found nothing anywhere for custom colors in any components in AUI, and that's something I think it's nice to have for a few components, such as buttons.

I will try to do my best and make the changes you've asked once I get enough time. Thank you again.

@guastallaigor
Copy link
Contributor Author

@damienix Please check if this new changes are ok for you. I changed the props from VaColor to VaType, and now the accepted values are just like VaMessage: 'error', 'warning', 'success' and 'info'.
Not sure if the code is great but it works for my needs at the moment.
Any changes just let me know. Thank you.

@damienix
Copy link
Contributor

Hi @guastallaigor.

I was on leave and still trying to catch up with everything. And you reported a lot of new stuff so a need to allocate some time on that :)

I'll try to review this in the upcoming days.
Cheers

@guastallaigor
Copy link
Contributor Author

Hello! Not a problem at all, you review all the things when you can :). No rush.
Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants