-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added prop color for a custom background color for the toggle button. #26
base: master
Are you sure you want to change the base?
Added prop color for a custom background color for the toggle button. #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, have you found this pattern (of coloring toggle button) somewhere in Jira or is this something that you came up with for your needs? If it's described somewhere (or used in Jira) I'd be more than happy to see it as I can't find it there.
This is something that I came up for my needs. I've found nothing anywhere for custom colors in any components in AUI, and that's something I think it's nice to have for a few components, such as buttons. I will try to do my best and make the changes you've asked once I get enough time. Thank you again. |
…d prop validation, success for default, just like VaMessage. Removed methods unused and data variables. Updated ToggleButtonDocs to this new prop type.
@damienix Please check if this new changes are ok for you. I changed the props from VaColor to VaType, and now the accepted values are just like VaMessage: 'error', 'warning', 'success' and 'info'. |
Hi @guastallaigor. I was on leave and still trying to catch up with everything. And you reported a lot of new stuff so a need to allocate some time on that :) I'll try to review this in the upcoming days. |
Hello! Not a problem at all, you review all the things when you can :). No rush. |
No description provided.