Testing for Shorthand Lookup #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n10v
reviewed
May 5, 2017
flag.go
Outdated
| @@ -327,7 +327,9 @@ func (f *FlagSet) ShorthandLookup(name string) *Flag { | |||
| return nil | |||
| } | |||
| if len(name) > 1 { | |||
| panic("can't look up for a shorthand with name more than one character") | |||
| msg := fmt.Sprintf("Can not look up shorthand which is more than one ASCII character: %q", name) | |||
There was a problem hiding this comment.
Please use the lower-case ("can't look up...")
|
fixed caps problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the example to make it clear that the string "verbose" is irrelevant to the lookup. (although still include the [:1] syntax).
Add some tests to shorthand lookup (len==0 and len >1)
Copy the Fprintf/panic pattern used on shorthand definition.