Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flag parameter 'ShowZeroValue' to show zero value in usage message #156

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GuillaumeSmaha
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Feb 7, 2018

CLA assistant check
All committers have signed the CLA.

@eparis
Copy link
Collaborator

eparis commented Feb 8, 2018

Can I ask why? And why is/should this be a property of the flagset and not of the individual flag?

@GuillaumeSmaha
Copy link
Author

I need to show the default value even if this is a zero value because I want a consistent rendering.

You are right, I will be more flexible to have the property on each flag instead on the flagset.

@GuillaumeSmaha GuillaumeSmaha changed the title Add FlagSet parameter 'ShowZeroValue' to show zero value in usage message Add Flag parameter 'ShowZeroValue' to show zero value in usage message Feb 9, 2018
@GuillaumeSmaha GuillaumeSmaha force-pushed the feature/add-flag-parameter-to-show-zero-value branch from 71c89ff to 7878f52 Compare February 9, 2018 15:45
@GuillaumeSmaha
Copy link
Author

Any news for this PR ?

@AdamSLevy
Copy link

Funny, I want a HideDefaultValue option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants