Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Value implementations public #223

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DenKoren
Copy link

this makes possible to do the following:

flag := pflag.Flag{
	Name:      "sample-option",
	Shorthand: "s",
	DefValue:  "default value",
	Value:     pflag.NewStringValue("default value", new(string)),
	Usage:     "option you can add to cobra command with Flags().AddFlag()",
}

cobra.Command{}.Flags().AddFlag(&flag)

It allows one to keep the flag definition separately and use the same flag in several CLI commands or subcommands.

cobra has AddFlag() method, but, as far as I see, user can't just make Flag structure and use it. The thing that causes problems is Value field: it requites Value interface implementation, but you can't access default implementations available inside pflag.
When Value field is nil, you face 'nil pointer dereference' error.

this makes possible to do the following:

flag := pflag.Flag{
	Name:      "sample-option",
	Shorthand: "s",
	DefValue:  "default value",
	Value:     pflag.NewStringValue("default value", new(string)),
	Usage:     "option you can add to cobra command with Flags().AddFlag()",
}

cobra.Command{}.Flags().AddFlag(&flag)
@CLAassistant
Copy link

CLAassistant commented Oct 24, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Korenevskiy Denis seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants