Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix TestSetOutput #225

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix TestSetOutput #225

wants to merge 2 commits into from

Conversation

cornfeedhobo
Copy link

@cornfeedhobo cornfeedhobo commented Nov 10, 2019 •
edited
Loading

The TestSetOutput test is silently failing since #144.

=== RUN   TestSetOutput
--- PASS: TestSetOutput (0.00s)
        flag_test.go:853: expected output mentioning unknown; got ""

This PR should fix that.

@cornfeedhobo cornfeedhobo mentioned this pull request Mar 4, 2020
Closed
@cornfeedhobo
Copy link
Author

@eparis @therealmitchconnors Could this PR get some attention?

@cornfeedhobo cornfeedhobo deleted the fix-setoutput-test branch October 1, 2020 20:27
@cornfeedhobo cornfeedhobo restored the fix-setoutput-test branch March 29, 2024 16:40
@cornfeedhobo cornfeedhobo reopened this Mar 29, 2024
@cornfeedhobo
Copy link
Author

@fredbi Now, that you have access and are looking into the testing situation, I've reopened this for your review. Thanks!

@fredbi
Copy link
Collaborator

fredbi commented Mar 29, 2024

Thanks @cornfeedhobo Will look at it over the week end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cornfeedhobo @fredbi