add Setter and Setv() #240
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this function allows one to set a Value that implements the Setter interface programmatically the setting should be absolute (since it isn't called by pflag internally, there are no scenarios where repeatedly calling it would happen) internal disambiguation happens so that, say, "1" is a valid value for a uint64 this also intelligently passes through string to Set() (unless this is a Value where Set() is meant to be called repeatedly)
|
As a sidenote, this can be made (somewhat) shorter using the "reflect" package, but I wasn't sure which would be preferable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message for details.
This functionality is primarily useful for users of pflag as an API, as it allows to Visit arbitrary flags and give them a typed value without needing the various
*Valuetypes exposed (while also integrating with user-defined Value implementations).In the future, it may be feasible to expand the given type uses of Setv().
Notes: