Custom flag's usage string shouldn't change its "defaults" section after parsing #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hoshsadiq
pushed a commit
to zulucmd/zflag
that referenced
this pull request
Feb 4, 2022
Right now the "defaults" section of the usage line of a custom flag is generated based on the value of "f.Value.String()" which can change after parsing. So the "usage" info returned by the following two types of invocation can be different: (--customFlag has no default) ./program --help ./program --customFlag=10 --help Merges spf13#243
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the "defaults" section of the usage line of a custom flag is generated based on the value of "f.Value.String()" which can change after parsing. So the "usage" info returned by the following two types pf invocation can be different:
(--customFlag has no default)
./program --help
./program --customFlag=10 --help