-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add unknown flags support #285
base: master
Are you sure you want to change the base?
Conversation
4f9eec8
to
33dec6a
Compare
There have been a few PRs related to the idea of tracking unknown fags. Can you explain why you chose this approach over #199? |
I didn't see #199, I fell that using flags and VisitUnknowns() may fit better the API and make it more elegant if one needs to iterate over unknown flags. But in the end I just need a way to retrieve unknown flags so one way or another I'm fine with it. |
@TiboStev Made a version of this on my fork. Feel free to check it out 😃 |
thanks for the review @cornfeedhobo I'll have a look |
Make able to use unknown flag and make it accessible for future use. For a wrapper for example