fix(shuffle+): update GraphQL handling #3229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use tracksV2 instead of tracks Use queryArtistOverview from Definitions object Use hard-coded queryArtistDiscographyAll definition
|
Much needed. Was waiting on a fix for this |
rxri
requested changes
Nov 30, 2024
Extensions/shuffle+.js
Outdated
| @@ -368,12 +368,12 @@ | |||
| } | |||
|
|
|||
| async function fetchArtistTracks(uri) { | |||
| const { queryArtistDiscographyAll } = Spicetify.GraphQL.Definitions; | |||
| const { queryArtistOverview } = Spicetify.GraphQL.Definitions; | |||
There was a problem hiding this comment.
queryArtistOverview is not available in some of supported spotify versions. revert.
Extensions/shuffle+.js
Outdated
| @@ -338,7 +338,7 @@ | |||
| if (errors) throw errors[0].message; | |||
| if (data.albumUnion.playability.playable === false) throw "Album is not playable"; | |||
|
|
|||
| return data.albumUnion.tracks.items.filter(({ track }) => track.playability.playable).map(({ track }) => (includeMetadata ? track : track.uri)); | |||
| return data.albumUnion.tracksV2.items.filter(({ track }) => track.playability.playable).map(({ track }) => (includeMetadata ? track : track.uri)); | |||
There was a problem hiding this comment.
is not available in all supported spotify versions.
Suggested change
| return data.albumUnion.tracksV2.items.filter(({ track }) => track.playability.playable).map(({ track }) => (includeMetadata ? track : track.uri)); | |
| return (data.albumUnion?.tracksV2 ?? data.albumUnion?.tracks).items.filter(({ track }) => track.playability.playable).map(({ track }) => (includeMetadata ? track : track.uri)); |
rxri
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracksV2instead oftracks(if supported) when fetching album tracksqueryArtistDiscographyAlldefinition (due to Spotify v1.2.46; see this PR)