Add 15.0, FontAwesome 4.7 and fix typos #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Purpose =========== As of version 15.0, Odoo is still using Font Awesome 4.7 for its icons. It can hence be useful to have it as an option to have a coherent icon with the rest of Odoo. This commit adds support for FontAwesome 4.7, adds 15.0 to the list (icon style has not changed since 12.0), and fixes a few typos.
|
@spilymp are there any plans to merge this? :) |
|
hi @spilymp |
|
Sincere thanks for your contribution and patience! I have merged your pull request. However, I did not understand the meaning of your additional JavaScript function. Therefore I have changed some things afterwards. If there are any errors or if this function serves an important purpose, please comment here or create a separate issue for it. |
|
Hi @spilymp , thanks for the merge! Everything seems to work correctly (except using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
As of version 15.0, Odoo is still using Font Awesome 4.7 for its icons.
It can hence be useful to have it as an option to have a coherent icon
with the rest of Odoo.
This commit adds support for FontAwesome 4.7, adds 15.0 to the list
(icon style has not changed since 12.0), and fixes a few typos.