-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor workflows to separate different conditions #27
Conversation
4c1aed8
to
75af7ec
Compare
75af7ec
to
80b8c72
Compare
The download wheels from PyPI step was inconsistent for 3.8 since Spine supports Python >=3.8.1. Remove this problem by switching to "Build with the newest supported Python" instead of "Build with the oldest supported Python". This should be fine, because now the build process is isolated, and doesn't execute any code from the package. See: #31 (comment)
If installed one by one, it pulls in spine dependencies from PyPI instead of the local wheels. Depending on the run, this could be incorrect.
if:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not an expert on GitHub actions, but by a cursory look, the changes seem sound. I guess I'll see how they work in real life next time I need to release new Toolbox :) Nice work!
Thanks! I did quite a bit of testing on the toy repo. Actually, that |
Summary
pip install *.whl
means spine dependencies are satisfied locally, no risk of pulling in unknown versions from PyPI.if skip: download else: build
)Testing of the action in the toy repo can be found here.
Unfortunately I had to delete the new tags from the example repos (
scm*
) otherwise it interferes with the unit tests here. I need to come up with a better way to setup the unit tests 🤔.Deleted tags on
scm*
:scm
: 0.7.3, 0.7.4scm-dep
: 0.2.4scm-base
: 0.3.3Related
Supersedes #23