feat(api): Enable parsing of YAML anchors and aliases #1427
Conversation
| resources: | ||
| - kind: ec2/security-group@v1 | ||
| spec: | ||
| << : *secgrp |
There was a problem hiding this comment.
@nimakaviani Note that this is slightly different than your example because we do additional validation of the delivery config and verify that resource IDs (which derive from the moniker field) are unique. IMO this is a good-enough compromise, but wanted to give you a heads-up.
There was a problem hiding this comment.
looks great thanks!
agreed. parsing is independent of the validation. As long as parsing works as expected, plugins can to decide at what level to use anchors and aliases and how to do the validations. so good enough IMO too. thanks again.
luispollo
force-pushed
the
two-pass-yaml-parsing
branch
from
e55b4bb to
7643beb
Compare
luispollo
force-pushed
the
two-pass-yaml-parsing
branch
from
7643beb to
8f543ee
Compare
|
I'm kind of stumped as to why this doesn't work out of the box given Jackson's YAML module uses SnakeYAML under the hood. Have we raised an issue on that repo? |
|
This seems relevant: FasterXML/jackson-dataformats-text#98 |
Yup. I referenced that exact same link in #1398 (comment) 🙂 |
Fixes #1398.
Cc: @nimakaviani