Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(vectorstore): introduce Step Builder pattern for PineconeVec… #2002

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sobychacko
Copy link
Contributor

…torStore

Replace the existing builder implementation with a type-safe Step Builder pattern to enforce required field initialization in a specific order. This change:

  • Introduces a new builder() method that guides users through required fields
  • Deprecates the old builder method with all parameters
  • Makes field configuration more explicit and type-safe
  • Updates all usage points to use the new builder pattern

The required fields must now be provided in sequence:

  1. embeddingModel
  2. apiKey
  3. projectId
  4. environment
  5. indexName

This change improves API usability by preventing parameter confusion and ensuring all required fields are set before optional configuration.

…torStore

Replace the existing builder implementation with a type-safe Step Builder pattern
to enforce required field initialization in a specific order. This change:

- Introduces a new builder() method that guides users through required fields
- Deprecates the old builder method with all parameters
- Makes field configuration more explicit and type-safe
- Updates all usage points to use the new builder pattern

The required fields must now be provided in sequence:
1. embeddingModel
2. apiKey
3. projectId
4. environment
5. indexName

This change improves API usability by preventing parameter confusion and ensuring
all required fields are set before optional configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant