Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Step names must be unique #3757 #4756

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Step names must be unique #3757 #4756

wants to merge 6 commits into from

Conversation

FBibonne
Copy link

@FBibonne FBibonne commented Feb 3, 2025

the names of different steps in a job must be different

Sloves #3757

A few comments :

  • pom is updated to have a have a version of slf4j-api corresponding to simple-slf4j
  • unicity of names is checked when starting the job , just before calling listeners because step names may be known only in JobScope
  • in FlowJob.findStepsThrowingIfNameNotUnique, I suggest to remove the else block when state is instance of StepHolder : it is never executed

Fabrice Bibonne and others added 6 commits February 3, 2025 05:30
@FBibonne
test(check unicity of job name in a flow) failing test
2d5335a 
Signed-off-by: Fabrice Bibonne <[email protected]>
@FBibonne
test(check unicity of job name in a flow) step name as a job parameter
fd184c3 
Signed-off-by: Fabrice Bibonne <[email protected]>
@FBibonne
fix(log for tests) print log in console for tests
9c6c392 
Signed-off-by: Fabrice Bibonne <[email protected]>
@FBibonne
feat(step name unicity) spring-projects#3757
6a5a14b 
the names of different steps in a job must be different

Signed-off-by: Fabrice Bibonne <[email protected]>
@FBibonne
fix(step name unicity WITHIN A FLOW)
1afb9ab 
Signed-off-by: Fabrice Bibonne <[email protected]>
@FBibonne
fix(java format)
03c8223 
  Also change copyright date to 2025

Signed-off-by: Fabrice Bibonne <[email protected]>
@FBibonne FBibonne mentioned this pull request Feb 3, 2025
Closed
@FBibonne
Copy link
Author

FBibonne commented Feb 3, 2025

this PR makes the same changes as #4544 which was closed dur to trouble with git

@FBibonne FBibonne mentioned this pull request Feb 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@FBibonne