-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Assets or Resources based on platform. #8636
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yschimke
force-pushed
the
assets_resources
branch
from
December 27, 2024 18:48
9441d0a
to
131ff8d
Compare
yschimke
changed the title
Use Assets and Resources based on platform.
Use Assets or Resources based on platform.
Dec 27, 2024
Androidx Startup approach fails with https://github.com/square/okhttp/actions/runs/12520208963/job/34925534823?pr=8636
|
yschimke
commented
Dec 28, 2024
androidx.startup is the right choice, though. The cost of each content provider is non-zero. Animal sniffer needs changed to run on the extracted jars from the aars, or just dropped from use on the Android target. |
Assets uncompressed on Android. Assuming that the AAR file will compress. Use Resources, compressed on JVM.
yschimke
force-pushed
the
assets_resources
branch
from
December 31, 2024 10:49
b4620ec
to
1a14ed4
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assets uncompressed on Android. Assuming that the AAR file will compress.
Use Resources, compressed on JVM.
Includes
an Androidx Startup Initializera ContentProvider to grab the app context.